# Re: \[PATCH RFC 3/5\] powerpc/speculation: Add support for 'cpu\_spec\_mitigations=' cmdline options

- From: Timothy Pearson \<tpearson@raptorengineering.com\>
- Date: 2019-04-04 20:09:52 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/04/5561741
- Thread: https://ratatoskr.run/linux-s390/2019/04/5561524/t.md

```text
Will be joining in ~ 5 mins.  Getting Chromium set up here.

----- Original Message -----
> From: "Jiri Kosina" <jikos@kernel.org>
> To: "Josh Poimboeuf" <redacted>
> Cc: "Peter Zijlstra" <peterz@infradead.org>, "Heiko Carstens" <redacted>, "Paul Mackerras"
> [ref], "H . Peter Anvin" [ref], "Ingo Molnar" [ref], "Andrea Arcangeli"
> [ref], linux-s390@vger.kernel.org, x86@kernel.org, "Will Deacon" [ref], "Linus
> Torvalds" [ref], "Catalin Marinas" [ref], "Waiman Long"
> [ref], linux-arch@vger.kernel.org, "Jon Masters" [ref], "Borislav Petkov" [ref],
> "Andy Lutomirski" [ref], "Thomas Gleixner" [ref], linux-arm-kernel@lists.infradead.org,
> "Greg Kroah-Hartman" [ref], linux-kernel@vger.kernel.org, "Tyler Hicks" [ref],
> "Martin Schwidefsky" [ref], linuxppc-dev@lists.ozlabs.org
> Sent: Thursday, April 4, 2019 2:49:05 PM
> Subject: Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

> On Thu, 4 Apr 2019, Josh Poimboeuf wrote:
> 
>> Configure powerpc CPU runtime speculation bug mitigations in accordance
>> with the 'cpu_spec_mitigations=' cmdline options.  This affects
>> Meltdown, Spectre v1, Spectre v2, and Speculative Store Bypass.
> [ ... snip ... ]
>> -	if (!no_nospec)
>> +	if (!no_nospec && cpu_spec_mitigations != CPU_SPEC_MITIGATIONS_OFF)
> 
> '!no_nospec' is something that I am sure will come back to hunt me in my
> bad dreams.
> 
> But that's been there already, and fixing it is out of scope of this
> patch. Other than that, as discussed previously -- I really like this new
> global option. Feel free to add
> 
>	Reviewed-by: Jiri Kosina <redacted>
> 
> for the whole set.
> 
> Thanks,
> 
> --
> Jiri Kosina
> SUSE Labs
```
