[PATCH] Disable kcov for slb routines.

From: Mahesh Salgaonkar <redacted>

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar <redacted>
---
 arch/powerpc/mm/Makefile |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
index d4d32e229ace..f9cb40684746 100644
--- a/arch/powerpc/mm/Makefile
+++ b/arch/powerpc/mm/Makefile

@@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS)	+= pkeys.o
 # This is necessary for booting with kcov enabled on book3e machines
 KCOV_INSTRUMENT_tlb_nohash.o := n
 KCOV_INSTRUMENT_fsl_booke_mmu.o := n
+KCOV_INSTRUMENT_slb.o := n

On 4/3/19 7:25 pm, Mahesh J Salgaonkar wrote:

From: Mahesh Salgaonkar <redacted>

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar <redacted>

Summary line needs a powerpc:

The SLB stuff isn't related to the book3e issues, I'd appreciate a 
separate comment here.

Otherwise

Acked-by: Andrew Donnellan <redacted>



-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

On Mon, Mar 04, 2019 at 01:55:51PM +0530, Mahesh J Salgaonkar wrote:

From: Mahesh Salgaonkar <redacted>

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar <redacted>
---
 arch/powerpc/mm/Makefile |    1 +
 1 file changed, 1 insertion(+)

Fixes: https://github.com/linuxppc/issues/issues/230

Tested-by: Satheesh Rajendran <redacted>

On Mon, 2019-03-04 at 08:25:51 UTC, Mahesh J Salgaonkar wrote:

From: Mahesh Salgaonkar <redacted>

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar <redacted>
Acked-by: Andrew Donnellan <redacted>
Tested-by: Satheesh Rajendran <redacted>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/19d6907521b04206676741b26e05a152

cheers

On 3/14/19 5:13 PM, Michael Ellerman wrote:

On Mon, 2019-03-04 at 08:25:51 UTC, Mahesh J Salgaonkar wrote:

quoted

From: Mahesh Salgaonkar <redacted>

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar <redacted>
Acked-by: Andrew Donnellan <redacted>
Tested-by: Satheesh Rajendran <redacted>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/19d6907521b04206676741b26e05a152

cheers

There was a v2 at http://patchwork.ozlabs.org/patch/1051718/, looks like
v1 got picked up. But I see the applied commit does address Andrew's
comments.

Thanks,
-Mahesh.

Mahesh Jagannath Salgaonkar [off-list ref] writes:

On 3/14/19 5:13 PM, Michael Ellerman wrote:

quoted

On Mon, 2019-03-04 at 08:25:51 UTC, Mahesh J Salgaonkar wrote:

quoted

From: Mahesh Salgaonkar <redacted>

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar <redacted>
Acked-by: Andrew Donnellan <redacted>
Tested-by: Satheesh Rajendran <redacted>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/19d6907521b04206676741b26e05a152

cheers

There was a v2 at http://patchwork.ozlabs.org/patch/1051718/, looks like
v1 got picked up. But I see the applied commit does address Andrew's
comments.

Sorry not sure how I missed v2.

cheers