[PATCH] powerpc: remote save_stack_trace_tsk_reliable export

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2747d

3 messages, 3 authors, 2019-03-04 · open the first message on its own page

[PATCH] powerpc: remote save_stack_trace_tsk_reliable export

From: Joe Lawrence <joe.lawrence@redhat.com>
Date: 2019-03-01 19:19:15

As tglx points out, there are no in-tree module users of
save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
so remove the powerpc symbol export.

Suggested-by: Thomas Gleixner <redacted>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---
 arch/powerpc/kernel/stacktrace.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index e2c50b55138f..42c587de21a9 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -193,7 +193,6 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
 	}
 	return 0;
 }
-EXPORT_SYMBOL_GPL(save_stack_trace_tsk_reliable);
 #endif /* CONFIG_HAVE_RELIABLE_STACKTRACE */
 
 #if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_NMI_IPI)
-- 
2.20.1

Re: [PATCH] powerpc: remote save_stack_trace_tsk_reliable export

From: "Singh, Balbir" <bsingharora@gmail.com>
Date: 2019-03-03 20:06:46


On 3/1/19 11:17 AM, Joe Lawrence wrote:
quoted hunk
As tglx points out, there are no in-tree module users of
save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
so remove the powerpc symbol export.

Suggested-by: Thomas Gleixner <redacted>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---
 arch/powerpc/kernel/stacktrace.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index e2c50b55138f..42c587de21a9 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -193,7 +193,6 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
 	}
 	return 0;
 }
-EXPORT_SYMBOL_GPL(save_stack_trace_tsk_reliable);
 #endif /* CONFIG_HAVE_RELIABLE_STACKTRACE */
 
 #if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_NMI_IPI)

Acked-by: Balbir Singh <bsingharora@gmail.com>

Balbir Singh

Re: powerpc: remote save_stack_trace_tsk_reliable export

From: Michael Ellerman <hidden>
Date: 2019-03-04 00:59:18

On Fri, 2019-03-01 at 19:17:21 UTC, Joe Lawrence wrote:
As tglx points out, there are no in-tree module users of
save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
so remove the powerpc symbol export.

Suggested-by: Thomas Gleixner <redacted>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
Acked-by: Balbir Singh <bsingharora@gmail.com>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/39070a96a1c2c502b2f77972ba8c2eba

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help