[PATCH] powerpc: remove dead code in head_fsl_booke.S

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2703d

4 messages, 3 authors, 2019-03-14 · open the first message on its own page

[PATCH] powerpc: remove dead code in head_fsl_booke.S

From: Jason Yan <yanaijie@huawei.com>
Date: 2019-02-28 09:05:24

This code is dead. Just remove it.

Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 arch/powerpc/kernel/head_fsl_booke.S | 7 -------
 1 file changed, 7 deletions(-)
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index 2386ce2a9c6e..b8450f017d85 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -194,13 +194,6 @@ set_ivor:
 #endif
 	mtspr	SPRN_MAS4, r2
 
-#if 0
-	/* Enable DOZE */
-	mfspr	r2,SPRN_HID0
-	oris	r2,r2,HID0_DOZE@h
-	mtspr	SPRN_HID0, r2
-#endif
-
 #if !defined(CONFIG_BDI_SWITCH)
 	/*
 	 * The Abatron BDI JTAG debugger does not tolerate others
-- 
2.14.5

Re: [PATCH] powerpc: remove dead code in head_fsl_booke.S

From: Christophe Leroy <hidden>
Date: 2019-02-28 13:04:57


Le 28/02/2019 à 09:31, Jason Yan a écrit :
This code is dead. Just remove it.

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Christophe Leroy <redacted>

This review was easy :)

Christophe
quoted hunk
---
  arch/powerpc/kernel/head_fsl_booke.S | 7 -------
  1 file changed, 7 deletions(-)
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index 2386ce2a9c6e..b8450f017d85 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -194,13 +194,6 @@ set_ivor:
  #endif
  	mtspr	SPRN_MAS4, r2
  
-#if 0
-	/* Enable DOZE */
-	mfspr	r2,SPRN_HID0
-	oris	r2,r2,HID0_DOZE@h
-	mtspr	SPRN_HID0, r2
-#endif
-
  #if !defined(CONFIG_BDI_SWITCH)
  	/*
  	 * The Abatron BDI JTAG debugger does not tolerate others

Re: [PATCH] powerpc: remove dead code in head_fsl_booke.S

From: Jason Yan <yanaijie@huawei.com>
Date: 2019-03-04 01:29:54


On 2019/2/28 21:00, Christophe Leroy wrote:

Le 28/02/2019 à 09:31, Jason Yan a écrit :
quoted
This code is dead. Just remove it.

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Christophe Leroy <redacted>

This review was easy :)

Christophe
Christophe, thanks.

quoted
---
  arch/powerpc/kernel/head_fsl_booke.S | 7 -------
  1 file changed, 7 deletions(-)
diff --git a/arch/powerpc/kernel/head_fsl_booke.S 
b/arch/powerpc/kernel/head_fsl_booke.S
index 2386ce2a9c6e..b8450f017d85 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -194,13 +194,6 @@ set_ivor:
  #endif
      mtspr    SPRN_MAS4, r2
-#if 0
-    /* Enable DOZE */
-    mfspr    r2,SPRN_HID0
-    oris    r2,r2,HID0_DOZE@h
-    mtspr    SPRN_HID0, r2
-#endif
-
  #if !defined(CONFIG_BDI_SWITCH)
      /*
       * The Abatron BDI JTAG debugger does not tolerate others
.

Re: powerpc: remove dead code in head_fsl_booke.S

From: Michael Ellerman <hidden>
Date: 2019-03-14 11:48:37

On Thu, 2019-02-28 at 08:31:21 UTC, Jason Yan wrote:
This code is dead. Just remove it.

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Christophe Leroy <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e585f51c4ee00046175ace52ca87ea47

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help