[PATCH] powerpc/mm: Check secondary hash page table

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2720d

2 messages, 2 authors, 2019-03-04 · open the first message on its own page

[PATCH] powerpc/mm: Check secondary hash page table

From: Rashmica Gupta <hidden>
Date: 2019-02-12 23:31:55

We were always calling base_hpte_find() with primary = true,
even when we wanted to check the secondary table...

Fixes: 1515ab932156 powerpc/mm: Dump hash table

Signed-off-by: Rashmica Gupta <redacted>
---

Thanks Paul for spotting this :)

 arch/powerpc/mm/dump_hashpagetable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/dump_hashpagetable.c b/arch/powerpc/mm/dump_hashpagetable.c
index 869294695048..b430e4e08af6 100644
--- a/arch/powerpc/mm/dump_hashpagetable.c
+++ b/arch/powerpc/mm/dump_hashpagetable.c
@@ -342,7 +342,7 @@ static unsigned long hpte_find(struct pg_state *st, unsigned long ea, int psize)
 
 	/* Look in secondary table */
 	if (slot == -1)
-		slot = base_hpte_find(ea, psize, true, &v, &r);
+		slot = base_hpte_find(ea, psize, false, &v, &r);
 
 	/* No entry found */
 	if (slot == -1)
-- 
2.17.2

Re: powerpc/mm: Check secondary hash page table

From: Michael Ellerman <hidden>
Date: 2019-03-04 00:53:01

On Tue, 2019-02-12 at 23:29:49 UTC, Rashmica Gupta wrote:
We were always calling base_hpte_find() with primary = true,
even when we wanted to check the secondary table...

Fixes: 1515ab932156 powerpc/mm: Dump hash table

Signed-off-by: Rashmica Gupta <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/790845e2f12709d273d08ea7a2af7c25

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help