# Re: \[PATCH 21/21\] memblock: drop memblock\_alloc\_\*\_nopanic() variants

- From: Greg Kroah-Hartman \<gregkh@linuxfoundation.org\>
- Date: 2019-01-18 08:42:37 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/01/5487205
- Thread: https://ratatoskr.run/linux-mm/2019/01/5485272/t.md

```text
On Wed, Jan 16, 2019 at 03:44:21PM +0200, Mike Rapoport wrote:
> As all the memblock allocation functions return NULL in case of error
> rather than panic(), the duplicates with _nopanic suffix can be removed.
> 
> Signed-off-by: Mike Rapoport <redacted>
> ---
>  arch/arc/kernel/unwind.c       |  3 +--
>  arch/sh/mm/init.c              |  2 +-
>  arch/x86/kernel/setup_percpu.c | 10 +++++-----
>  arch/x86/mm/kasan_init_64.c    | 14 ++++++++------
>  drivers/firmware/memmap.c      |  2 +-
>  drivers/usb/early/xhci-dbc.c   |  2 +-
>  include/linux/memblock.h       | 35 -----------------------------------
>  kernel/dma/swiotlb.c           |  2 +-
>  kernel/printk/printk.c         | 17 +++++++----------
>  mm/memblock.c                  | 35 -----------------------------------
>  mm/page_alloc.c                | 10 +++++-----
>  mm/page_ext.c                  |  2 +-
>  mm/percpu.c                    | 11 ++++-------
>  mm/sparse.c                    |  6 ++----
>  14 files changed, 37 insertions(+), 114 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
