[PATCH] net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe()

Subsystems: freescale quicc engine ucc hdlc driver, networking drivers, the rest

STALE2775d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2018-12-28 · open the first message on its own page

[PATCH] net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe()

From: Peng Hao <hidden>
Date: 2018-12-26 08:07:40

From: Wen Yang <redacted>

This patch fixes potential double frees if register_hdlc_device() fails.

Signed-off-by: Wen Yang <redacted>
Reviewed-by: Peng Hao <redacted>
CC: Zhao Qiang <qiang.zhao@nxp.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
CC: linuxppc-dev@lists.ozlabs.org
CC: linux-kernel@vger.kernel.org
---
 drivers/net/wan/fsl_ucc_hdlc.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 7a42336..839fa77 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -1180,7 +1180,6 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
 	if (register_hdlc_device(dev)) {
 		ret = -ENOBUFS;
 		pr_err("ucc_hdlc: unable to register hdlc device\n");
-		free_netdev(dev);
 		goto free_dev;
 	}
 
-- 
2.9.5

Re: [PATCH] net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe()

From: David Miller <davem@davemloft.net>
Date: 2018-12-28 00:28:43

From: Peng Hao <redacted>
Date: Wed, 26 Dec 2018 16:28:30 +0800
From: Wen Yang <redacted>

This patch fixes potential double frees if register_hdlc_device() fails.

Signed-off-by: Wen Yang <redacted>
Reviewed-by: Peng Hao <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help