[PATCH] powerpc: mark 64-bit PD_HUGE constant as unsigned long

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2843d

2 messages, 2 authors, 2018-11-27 · open the first message on its own page

[PATCH] powerpc: mark 64-bit PD_HUGE constant as unsigned long

From: Daniel Axtens <hidden>
Date: 2018-11-06 14:50:50

When compiled for 64-bit, the PD_HUGE constant is a 64-bit integer.
Mark it as an unsigned long.

This squashes over a thousand sparse warnings on my minimal T4240RDB
(e6500, ppc64be) config, of the following 2 forms:

arch/powerpc/include/asm/hugetlb.h:52:49: warning: constant 0x8000000000000000 is so big it is unsigned long
arch/powerpc/include/asm/nohash/pgtable.h:269:49: warning: constant 0x8000000000000000 is so big it is unsigned long

Signed-off-by: Daniel Axtens <redacted>

---

Boot tested on a T4240RDB.
---
 arch/powerpc/include/asm/page.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
index f6a1265face2..9ea903221a9f 100644
--- a/arch/powerpc/include/asm/page.h
+++ b/arch/powerpc/include/asm/page.h
@@ -289,7 +289,7 @@ static inline bool pfn_valid(unsigned long pfn)
  * page tables at arbitrary addresses, this breaks and will have to change.
  */
 #ifdef CONFIG_PPC64
-#define PD_HUGE 0x8000000000000000
+#define PD_HUGE 0x8000000000000000UL
 #else
 #define PD_HUGE 0x80000000
 #endif
-- 
2.17.1

Re: powerpc: mark 64-bit PD_HUGE constant as unsigned long

From: Michael Ellerman <hidden>
Date: 2018-11-27 09:44:04

On Tue, 2018-11-06 at 14:48:03 UTC, Daniel Axtens wrote:
When compiled for 64-bit, the PD_HUGE constant is a 64-bit integer.
Mark it as an unsigned long.

This squashes over a thousand sparse warnings on my minimal T4240RDB
(e6500, ppc64be) config, of the following 2 forms:

arch/powerpc/include/asm/hugetlb.h:52:49: warning: constant 0x8000000000000000 is so big it is unsigned long
arch/powerpc/include/asm/nohash/pgtable.h:269:49: warning: constant 0x8000000000000000 is so big it is unsigned long

Signed-off-by: Daniel Axtens <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/d456f3529a7a980ca7410c62e9e349

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help