# Re: \[PATCH\] powerpc/rtasd: Improve unknown error logging

- From: Vasant Hegde \<hidden\>
- Date: 2018-10-10 05:52:28 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2018/10/9506642
- Thread: https://ratatoskr.run/linuxppc-dev/2018/10/9506640/t.md

```text
On 10/10/2018 10:53 AM, Oliver O'Halloran wrote:
> Currently when we get an unknown RTAS event it prints the type as
> "Unknown" and no other useful information. Add the raw type code to the
> log message so that we have something to work off.

Yeah. Useful one.

Reviewed-by: Vasant Hegde <redacted>

-Vasant

>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
>   arch/powerpc/kernel/rtasd.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
> index 44d66c33d59d..6fafc82c04b0 100644
> --- a/arch/powerpc/kernel/rtasd.c
> +++ b/arch/powerpc/kernel/rtasd.c
> @@ -150,8 +150,10 @@ static void printk_log_rtas(char *buf, int len)
>   	} else {
>   		struct rtas_error_log *errlog = (struct rtas_error_log *)buf;
>
> -		printk(RTAS_DEBUG "event: %d, Type: %s, Severity: %d\n",
> -		       error_log_cnt, rtas_event_type(rtas_error_type(errlog)),
> +		printk(RTAS_DEBUG "event: %d, Type: %s (%d), Severity: %d\n",
> +		       error_log_cnt,
> +		       rtas_event_type(rtas_error_type(errlog)),
> +		       rtas_error_type(errlog),
>   		       rtas_error_severity(errlog));
>   	}
>   }
>

```