Re: [PATCH v4] powerpc: Avoid code patching freed init sections

On Sep 14 2018, Michael Neuling [off-list ref] wrote:

This stops us from doing code patching in init sections after they've
been freed.

This breaks booting on PowerBook6,7, crashing very early.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

On Tue, 2018-10-02 at 23:35 +0200, Andreas Schwab wrote:

On Sep 14 2018, Michael Neuling [off-list ref] wrote:

quoted

This stops us from doing code patching in init sections after they've
been freed.

This breaks booting on PowerBook6,7, crashing very early.

Sorry, Can you try?

http://patchwork.ozlabs.org/patch/977195/

Mikey

Andreas Schwab [off-list ref] writes:

On Sep 14 2018, Michael Neuling [off-list ref] wrote:

quoted

This stops us from doing code patching in init sections after they've
been freed.

This breaks booting on PowerBook6,7, crashing very early.

Crud, sorry.

My CI setup tests with the mac99 qemu model, but that boots happily, not
sure why.

cheers

Le 03/10/2018 à 05:20, Michael Ellerman a écrit :

Andreas Schwab [off-list ref] writes:

quoted

On Sep 14 2018, Michael Neuling [off-list ref] wrote:

quoted

This stops us from doing code patching in init sections after they've
been freed.

This breaks booting on PowerBook6,7, crashing very early.

Crud, sorry.

My CI setup tests with the mac99 qemu model, but that boots happily, not
sure why.

Maybe mac99 doesn't use relocation ?

The issue is that during early boot, 'init_mem_is_free' is not yet at 
its definitif address.

I sent a fix for it : https://patchwork.ozlabs.org/patch/977195/

Christophe