[PATCH] powerpc/io: remove old GCC version implementation

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2884d

5 messages, 4 authors, 2018-10-19 · open the first message on its own page

[PATCH] powerpc/io: remove old GCC version implementation

From: Christophe Leroy <hidden>
Date: 2018-10-16 12:33:44

GCC 4.6 is the minimum supported now.

Signed-off-by: Christophe Leroy <redacted>
---
 arch/powerpc/include/asm/io.h | 20 --------------------
 1 file changed, 20 deletions(-)
diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
index 0a034519957d..3ef40b703c4a 100644
--- a/arch/powerpc/include/asm/io.h
+++ b/arch/powerpc/include/asm/io.h
@@ -111,25 +111,6 @@ extern bool isa_io_special;
 #define IO_SET_SYNC_FLAG()
 #endif
 
-/* gcc 4.0 and older doesn't have 'Z' constraint */
-#if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ == 0)
-#define DEF_MMIO_IN_X(name, size, insn)				\
-static inline u##size name(const volatile u##size __iomem *addr)	\
-{									\
-	u##size ret;							\
-	__asm__ __volatile__("sync;"#insn" %0,0,%1;twi 0,%0,0;isync"	\
-		: "=r" (ret) : "r" (addr), "m" (*addr) : "memory");	\
-	return ret;							\
-}
-
-#define DEF_MMIO_OUT_X(name, size, insn)				\
-static inline void name(volatile u##size __iomem *addr, u##size val)	\
-{									\
-	__asm__ __volatile__("sync;"#insn" %1,0,%2"			\
-		: "=m" (*addr) : "r" (val), "r" (addr) : "memory");	\
-	IO_SET_SYNC_FLAG();						\
-}
-#else /* newer gcc */
 #define DEF_MMIO_IN_X(name, size, insn)				\
 static inline u##size name(const volatile u##size __iomem *addr)	\
 {									\
@@ -146,7 +127,6 @@ static inline void name(volatile u##size __iomem *addr, u##size val)	\
 		: "=Z" (*addr) : "r" (val) : "memory");			\
 	IO_SET_SYNC_FLAG();						\
 }
-#endif
 
 #define DEF_MMIO_IN_D(name, size, insn)				\
 static inline u##size name(const volatile u##size __iomem *addr)	\
-- 
2.13.3

Re: [PATCH] powerpc/io: remove old GCC version implementation

From: Joakim Tjernlund <hidden>
Date: 2018-10-16 12:49:21

On Tue, 2018-10-16 at 12:33 +0000, Christophe Leroy wrote:

GCC 4.6 is the minimum supported now.
Ouch, from kernel 4.19 or earlier even ?

 Jocke

Re: [PATCH] powerpc/io: remove old GCC version implementation

From: Christophe LEROY <hidden>
Date: 2018-10-16 13:17:34


Le 16/10/2018 à 14:49, Joakim Tjernlund a écrit :
On Tue, 2018-10-16 at 12:33 +0000, Christophe Leroy wrote:
quoted

GCC 4.6 is the minimum supported now.
Ouch, from kernel 4.19 or earlier even ?
Don't know, see 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cafa0010

Christophe

Re: [PATCH] powerpc/io: remove old GCC version implementation

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-10-17 00:51:11

Joakim Tjernlund [off-list ref] writes:
On Tue, 2018-10-16 at 12:33 +0000, Christophe Leroy wrote:
quoted

GCC 4.6 is the minimum supported now.
Ouch, from kernel 4.19 or earlier even ?
Yes.

Though to be honest we haven't been testing much with compilers older
than that for several years.

If you care about something older please let us know :)

cheers

Re: powerpc/io: remove old GCC version implementation

From: Michael Ellerman <hidden>
Date: 2018-10-19 02:51:30

On Tue, 2018-10-16 at 12:33:40 UTC, Christophe Leroy wrote:
GCC 4.6 is the minimum supported now.

Signed-off-by: Christophe Leroy <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/a0e102914aa3f619a5bc68a0d33e17

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help