Re: [PATCH v2 2/6] net/wan/fsl_ucc_hdlc: allow PARITY_CRC16_PR0_CCITT parity
From: christophe leroy <hidden>
Date: 2018-09-01 08:11:36
Also in:
netdev
Le 29/08/2018 à 15:13, David Gounaris a écrit :
quoted hunk ↗ jump to hunk
Signed-off-by: David Gounaris <redacted> --- drivers/net/wan/fsl_ucc_hdlc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 5cf6dcba039c..c8e526bf1130 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c@@ -781,7 +781,8 @@ static int ucc_hdlc_attach(struct net_device *dev, unsigned short encoding, if (parity != PARITY_NONE && parity != PARITY_CRC32_PR1_CCITT && - parity != PARITY_CRC16_PR1_CCITT) + parity != PARITY_CRC16_PR1_CCITT && + parity != PARITY_CRC16_PR0_CCITT)
ERROR:TRAILING_WHITESPACE: trailing whitespace #20: FILE: drivers/net/wan/fsl_ucc_hdlc.c:783: +^I parity != PARITY_CRC16_PR1_CCITT && $ Also, you could have left the line 'parity != PARITY_CRC16_PR1_CCITT)' as is and just have added 'parity != PARITY_CRC16_PR0_CCITT &&' on the previous line, would make more sense to have PR0 before PR1, and instead of having 2+1- you would only have 1+
return -EINVAL; priv->encoding = encoding;
--- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus