# Re: \[PATCH\] lib/xz: Put CRC32\_POLY\_LE in xz\_private.h

- From: Meelis Roos \<hidden\>
- Date: 2018-09-22 09:49:14 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2018/09/5387989
- Thread: https://ratatoskr.run/linuxppc-dev/2018/09/5386893/t.md

```text
> This fixes a regression introduced by faa16bc404d72a5 ("lib: Use
> existing define with polynomial").
> 
> The cleanup added a dependency on include/linux, which broke the PowerPC
> boot wrapper/decompresser when KERNEL_XZ is enabled:
> 
>   BOOTCC  arch/powerpc/boot/decompress.o
>  In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:233,
>                  from arch/powerpc/boot/decompress.c:42:
>  arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:10: fatal error:
>  linux/crc32poly.h: No such file or directory
>   #include <linux/crc32poly.h>
>            ^~~~~~~~~~~~~~~~~~~
> 
> The powerpc decompresser is a hairy corner of the kernel. Even while building
> a 64-bit kernel it needs to build a 32-bit binary and therefore avoid including
> files from include/linux.
> 
> This allows users of the xz library to avoid including headers from
> 'include/linux/' while still achieving the cleanup of the magic number.
> 
> Fixes: faa16bc404d72a5 ("lib: Use existing define with polynomial")
> Reported-by: Meelis Roos <redacted>
> Reported-by: kbuild test robot <redacted>
> Suggested-by: Christophe LEROY <redacted>
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Tested-by: Meelis Roos <redacted>

-- 
Meelis Roos (mroos@linux.ee)
```
