# Re: \[REVIEW\]\[PATCH 7/9\] signal/poewrpc: Specialize \_exception\_pkey for handling pkey exceptions

- From: Stephen Rothwell \<hidden\>
- Date: 2018-09-21 08:54:35 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2018/09/5387098
- Thread: https://ratatoskr.run/linux-arch/2018/09/5384332/t.md

```text
Hi Eric,

On Tue, 18 Sep 2018 19:58:48 +0200 "Eric W. Biederman" [ref] wrote:
>
> Now that _exception no longer calls _exception_pkey it is no longer
> necessary to handle any signal with any si_code.  All pkey exceptions
> are SIGSEGV with paired with SEGV_PKUERR.  So just handle
> that case and remove the now unnecessary parameters from _exception_pkey.
> 
> Signed-off-by: "Eric W. Biederman" <redacted>

Looks fine to me (small query below).

Reviewed-by: Stephen Rothwell <redacted>

>  	clear_siginfo(&info);
> -	info.si_signo = signr;
> -	info.si_code = code;
> +	info.si_signo = SIGSEGV;
> +	info.si_code = SEGV_PKUERR;
>  	info.si_addr = (void __user *) addr;
>  	info.si_pkey = key;
>  
> -	force_sig_info(signr, &info, current);
> +	force_sig_info(info.si_signo, &info, current);
                       ^^^^^^^^^^^^^
Why not just SIGSEGV?

-- 
Cheers,
Stephen Rothwell
```

## Attachments

- [(unnamed)](https://ratatoskr.run/linuxppc-dev/2018/09/5387098/attachment/0) (application/pgp-signature, 488 bytes)