[PATCH] powerpc/64: Remove static branch hints from memset()

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2873d

2 messages, 2 authors, 2018-09-20 · open the first message on its own page

[PATCH] powerpc/64: Remove static branch hints from memset()

From: Anton Blanchard <hidden>
Date: 2018-08-21 01:04:14

From: Anton Blanchard <redacted>

Static branch hints override dynamic branch prediction on recent
POWER CPUs. We should only use them when we are overwhelmingly
sure of the direction.

Signed-off-by: Anton Blanchard <redacted>
---
 arch/powerpc/lib/mem_64.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/lib/mem_64.S b/arch/powerpc/lib/mem_64.S
index ec531de99996..3c3be02f33b7 100644
--- a/arch/powerpc/lib/mem_64.S
+++ b/arch/powerpc/lib/mem_64.S
@@ -40,7 +40,7 @@ _GLOBAL(memset)
 .Lms:	PPC_MTOCRF(1,r0)
 	mr	r6,r3
 	blt	cr1,8f
-	beq+	3f			/* if already 8-byte aligned */
+	beq	3f			/* if already 8-byte aligned */
 	subf	r5,r0,r5
 	bf	31,1f
 	stb	r4,0(r6)
@@ -85,7 +85,7 @@ _GLOBAL(memset)
 	addi	r6,r6,8
 8:	cmpwi	r5,0
 	PPC_MTOCRF(1,r5)
-	beqlr+
+	beqlr
 	bf	29,9f
 	stw	r4,0(r6)
 	addi	r6,r6,4
-- 
2.17.1

Re: powerpc/64: Remove static branch hints from memset()

From: Michael Ellerman <hidden>
Date: 2018-09-20 04:20:58

On Tue, 2018-08-21 at 01:04:12 UTC, Anton Blanchard wrote:
From: Anton Blanchard <redacted>

Static branch hints override dynamic branch prediction on recent
POWER CPUs. We should only use them when we are overwhelmingly
sure of the direction.

Signed-off-by: Anton Blanchard <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/be54c1216f6689a6eb504e3471d0cb

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help