[RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

5 messages, 3 authors, 2018-08-29 · open the first message on its own page

[RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2018-08-29 07:32:33

After commit faa16bc404d7 ("lib: Use existing define with
polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
directory thus any other user of this code should define proper include
path.

This fixes the build error on powerpc with CONFIG_KERNEL_XZ:

    In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
                     from ../arch/powerpc/boot/decompress.c:42:
    ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory

Reported-by: Michal Kubecek <redacted>
Fixes: faa16bc404d7 ("lib: Use existing define with polynomial")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Only compile tested.
---
 arch/powerpc/boot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 0fb96c26136f..ba4182fb185d 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -63,7 +63,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y)
 BOOTCFLAGS	+= -fno-stack-protector
 endif
 
-BOOTCFLAGS	+= -I$(objtree)/$(obj) -I$(srctree)/$(obj)
+BOOTCFLAGS	+= -I$(objtree)/$(obj) -I$(srctree)/$(obj) -I$(srctree)/include
 
 DTC_FLAGS	?= -p 1024
 
-- 
2.7.4

Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2018-08-29 07:56:13

On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski [off-list ref] wrote:
After commit faa16bc404d7 ("lib: Use existing define with
polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
directory thus any other user of this code should define proper include
path.

This fixes the build error on powerpc with CONFIG_KERNEL_XZ:

    In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
                     from ../arch/powerpc/boot/decompress.c:42:
    ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory

Reported-by: Michal Kubecek <redacted>
Reported earlier by Kbuild:
https://lkml.org/lkml/2018/8/23/47

for the credits:
Reported-by: kbuild test robot <redacted>

Best regards,
Krzysztof

Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ

From: Mathieu Malaterre <hidden>
Date: 2018-08-29 08:07:01

On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski [off-list ref] wrote:
On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski [off-list ref] wrote:
quoted
After commit faa16bc404d7 ("lib: Use existing define with
polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
directory thus any other user of this code should define proper include
path.

This fixes the build error on powerpc with CONFIG_KERNEL_XZ:

    In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
                     from ../arch/powerpc/boot/decompress.c:42:
    ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory

Reported-by: Michal Kubecek <redacted>
Reported earlier by Kbuild:
https://lkml.org/lkml/2018/8/23/47

for the credits:
Reported-by: kbuild test robot <redacted>
Technically Meelis reported it earlier:

https://lkml.org/lkml/2018/8/22/365

;)

Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2018-08-29 08:12:59

On Wed, 29 Aug 2018 at 10:06, Mathieu Malaterre [off-list ref] wrote:
On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski [off-list ref] wrote:
quoted
On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski [off-list ref] wrote:
quoted
After commit faa16bc404d7 ("lib: Use existing define with
polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
directory thus any other user of this code should define proper include
path.

This fixes the build error on powerpc with CONFIG_KERNEL_XZ:

    In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
                     from ../arch/powerpc/boot/decompress.c:42:
    ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory

Reported-by: Michal Kubecek <redacted>
Reported earlier by Kbuild:
https://lkml.org/lkml/2018/8/23/47

for the credits:
Reported-by: kbuild test robot <redacted>
Technically Meelis reported it earlier:

https://lkml.org/lkml/2018/8/22/365

;)
Oh, right... so for the full credits:
Reported-by: Meelis Roos <redacted>

Best regards,
Krzysztof

Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ

From: Michal Kubecek <hidden>
Date: 2018-08-29 10:45:34

On Wed, Aug 29, 2018 at 09:32:23AM +0200, Krzysztof Kozlowski wrote:
quoted hunk
After commit faa16bc404d7 ("lib: Use existing define with
polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
directory thus any other user of this code should define proper include
path.

This fixes the build error on powerpc with CONFIG_KERNEL_XZ:

    In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
                     from ../arch/powerpc/boot/decompress.c:42:
    ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory

Reported-by: Michal Kubecek <redacted>
Fixes: faa16bc404d7 ("lib: Use existing define with polynomial")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Only compile tested.
---
 arch/powerpc/boot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 0fb96c26136f..ba4182fb185d 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -63,7 +63,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y)
 BOOTCFLAGS	+= -fno-stack-protector
 endif
 
-BOOTCFLAGS	+= -I$(objtree)/$(obj) -I$(srctree)/$(obj)
+BOOTCFLAGS	+= -I$(objtree)/$(obj) -I$(srctree)/$(obj) -I$(srctree)/include
 
 DTC_FLAGS	?= -p 1024
 
-- 
2.7.4
With this patch 4.19-rc1 builds and boots on ppc64le. Thank you.

Tested-by: Michal Kubecek <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help