# \[PATCH 0/6\] rapidio: move Kconfig menu definition to subsystem - Subsystems: LINUX FOR POWERPC (32-BIT AND 64-BIT), ARM PORT, ARM64 PORT (AARCH64 ARCHITECTURE), MIPS, RAPIDIO SUBSYSTEM, THE REST, X86 ARCHITECTURE (32-BIT AND 64-BIT) - Maintainers: Madhavan Srinivasan, Russell King, Catalin Marinas, Will Deacon, Thomas Bogendoerfer, Matt Porter, Alexandre Bounine, Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen - Series: 6 patches touching 6 files, +20/-31 - Revision v1 (2 revisions archived). - List: linuxppc-dev - 6 messages, 5 authors - Page: https://ratatoskr.run/linuxppc-dev/2018/07/5345967/t ## \[PATCH 0/6\] rapidio: move Kconfig menu definition to subsystem - From: Alexei Colin \ - Date: 2018-07-30 22:50:58 - Message: https://ratatoskr.run/linuxppc-dev/2018/07/5345967.md ```text The top-level Kconfig entry for RapidIO subsystem is currently duplicated in several architecture-specific Kconfig files. This set of patches does two things: 1. Move the Kconfig menu definition into the RapidIO subsystem and remove the duplicate definitions from arch Kconfig files. 2. Enable RapidIO Kconfig menu entry for arm and arm64 architectures, where it was not enabled before. I tested that subsystem and drivers build successfully for both architectures, and tested that the modules load on a custom arm64 Qemu model. For all architectures, RapidIO menu should be offered when either: (1) The platform has a PCI bus (which host a RapidIO module on the bus). (2) The platform has a RapidIO IP block (connected to a system bus, e.g. AXI on ARM). In this case, 'select HAS_RAPIDIO' should be added to the 'config ARCH_*' menu entry for the SoCs that offer the IP block. Prior to this patchset, different architectures used different criteria: * powerpc: (1) and (2) * mips: (1) and (2) after recent commit into next that added (2): https://www.linux-mips.org/archives/linux-mips/2018-07/msg00596.html fc5d988878942e9b42a4de5204bdd452f3f1ce47 491ec1553e0075f345fbe476a93775eabcbc40b6 * x86: (1) * arm,arm64: none (RapidIO menus never offered) Responses to feedback from prior submission (thanks for the reviews!): http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593347.html http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593349.html Changelog: * Moved Kconfig entry into RapidIO subsystem instead of duplicating In the current patchset, I took the approach of adding '|| PCI' to the depends in the subsystem. I did try the alterantive approach mentioned in the reviews for v1 of this patch, where the subsystem Kconfig does not add a '|| PCI' and each per-architecture Kconfig has to add a 'select HAS_RAPIDIO if PCI' and SoCs with IP blocks have to also add 'select HAS_RAPIDIO'. This works too but requires each architecture's Kconfig to add the line for RapidIO (whereas current approach does not require that involvement) and also may create a false impression that the dependency on PCI is strict. We appreciate the suggestion for also selecting the RapdiIO subsystem for compilation with COMPILE_TEST, but hope to address it in a separate patchset, localized to the subsystem, since it will need to change depends on all drivers, not just on the top level, and since this patch now spans multiple architectures. Alexei Colin (6): rapidio: define top Kconfig menu in driver subtree x86: factor out RapidIO Kconfig menu powerpc: factor out RapidIO Kconfig menu entry mips: factor out RapidIO Kconfig entry arm: enable RapidIO menu in Kconfig arm64: enable RapidIO menu in Kconfig arch/arm/Kconfig | 2 ++ arch/arm64/Kconfig | 2 ++ arch/mips/Kconfig | 11 ----------- arch/powerpc/Kconfig | 13 +------------ arch/x86/Kconfig | 8 -------- drivers/rapidio/Kconfig | 15 +++++++++++++++ 6 files changed, 20 insertions(+), 31 deletions(-) -- 2.18.0 ``` ## \[PATCH 3/6\] powerpc: factor out RapidIO Kconfig menu entry - From: Alexei Colin \ - Date: 2018-07-30 22:51:04 - Message: https://ratatoskr.run/linuxppc-dev/2018/07/5345969.md ```text The menu entry is now defined in the rapidio subtree. Also, re-order the bus menu so tha the platform-specific RapidIO controller appears after the entry for the RapidIO subsystem. Platforms with a PCI bus will be offered the RapidIO menu since they may be want support for a RapidIO PCI device. Platforms without a PCI bus that might include a RapidIO IP block will need to "select HAS_RAPIDIO" in the platform-/machine-specific "config ARCH_*" Kconfig entry. Cc: Andrew Morton Cc: John Paul Walters Cc: Cc: Signed-off-by: Alexei Colin --- arch/powerpc/Kconfig | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 25d005af0a5b..17ea8a5f90a0 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -993,16 +993,7 @@ source "drivers/pci/Kconfig" source "drivers/pcmcia/Kconfig" -config HAS_RAPIDIO - bool - default n - -config RAPIDIO - tristate "RapidIO support" - depends on HAS_RAPIDIO || PCI - help - If you say Y here, the kernel will include drivers and - infrastructure code to support RapidIO interconnect devices. +source "drivers/rapidio/Kconfig" config FSL_RIO bool "Freescale Embedded SRIO Controller support" @@ -1012,8 +1003,6 @@ config FSL_RIO Include support for RapidIO controller on Freescale embedded processors (MPC8548, MPC8641, etc). -source "drivers/rapidio/Kconfig" - endmenu config NONSTATIC_KERNEL -- 2.18.0 ``` ## Re: \[PATCH 0/6\] rapidio: move Kconfig menu definition to subsystem - From: Russell King - ARM Linux \ - Date: 2018-07-30 23:00:09 - Message: https://ratatoskr.run/linuxppc-dev/2018/07/5345979.md ```text I only have this message, and patches 5 and 6. This is meaningless for me to review - I can't tell what you've done as far as my comments on your previous iteration. Please arrange to _at least_ copy all patches the appropriate mailing lists for the set with your complete patch set if you aren't going to copy everyone on all patches in the set. On Mon, Jul 30, 2018 at 06:50:28PM -0400, Alexei Colin wrote: > In the current patchset, I took the approach of adding '|| PCI' to the > depends in the subsystem. I did try the alterantive approach mentioned > in the reviews for v1 of this patch, where the subsystem Kconfig does > not add a '|| PCI' and each per-architecture Kconfig has to add a > 'select HAS_RAPIDIO if PCI' and SoCs with IP blocks have to also add > 'select HAS_RAPIDIO'. This works too but requires each architecture's > Kconfig to add the line for RapidIO (whereas current approach does not > require that involvement) and also may create a false impression that > the dependency on PCI is strict. ... which means, as it stands, I've no idea what you actually came up with for this. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up ``` ## Re: \[PATCH 0/6\] rapidio: move Kconfig menu definition to subsystem - From: Randy Dunlap \ - Date: 2018-07-31 01:08:58 - Message: https://ratatoskr.run/linuxppc-dev/2018/07/5346050.md ```text On 07/30/2018 03:50 PM, Alexei Colin wrote: > The top-level Kconfig entry for RapidIO subsystem is currently > duplicated in several architecture-specific Kconfig files. This set of > patches does two things: > > 1. Move the Kconfig menu definition into the RapidIO subsystem and > remove the duplicate definitions from arch Kconfig files. > > 2. Enable RapidIO Kconfig menu entry for arm and arm64 architectures, > where it was not enabled before. I tested that subsystem and drivers > build successfully for both architectures, and tested that the modules > load on a custom arm64 Qemu model. > > For all architectures, RapidIO menu should be offered when either: > (1) The platform has a PCI bus (which host a RapidIO module on the bus). > (2) The platform has a RapidIO IP block (connected to a system bus, e.g. > AXI on ARM). In this case, 'select HAS_RAPIDIO' should be added to the > 'config ARCH_*' menu entry for the SoCs that offer the IP block. > > Prior to this patchset, different architectures used different criteria: > * powerpc: (1) and (2) > * mips: (1) and (2) after recent commit into next that added (2): > https://www.linux-mips.org/archives/linux-mips/2018-07/msg00596.html > fc5d988878942e9b42a4de5204bdd452f3f1ce47 > 491ec1553e0075f345fbe476a93775eabcbc40b6 > * x86: (1) > * arm,arm64: none (RapidIO menus never offered) > > Responses to feedback from prior submission (thanks for the reviews!): > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593347.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593349.html > > Changelog: > * Moved Kconfig entry into RapidIO subsystem instead of duplicating > > In the current patchset, I took the approach of adding '|| PCI' to the > depends in the subsystem. I did try the alterantive approach mentioned > in the reviews for v1 of this patch, where the subsystem Kconfig does > not add a '|| PCI' and each per-architecture Kconfig has to add a > 'select HAS_RAPIDIO if PCI' and SoCs with IP blocks have to also add > 'select HAS_RAPIDIO'. This works too but requires each architecture's > Kconfig to add the line for RapidIO (whereas current approach does not > require that involvement) and also may create a false impression that > the dependency on PCI is strict. > > We appreciate the suggestion for also selecting the RapdiIO subsystem for > compilation with COMPILE_TEST, but hope to address it in a separate > patchset, localized to the subsystem, since it will need to change > depends on all drivers, not just on the top level, and since this > patch now spans multiple architectures. > > > Alexei Colin (6): > rapidio: define top Kconfig menu in driver subtree > x86: factor out RapidIO Kconfig menu > powerpc: factor out RapidIO Kconfig menu entry > mips: factor out RapidIO Kconfig entry > arm: enable RapidIO menu in Kconfig > arm64: enable RapidIO menu in Kconfig > > arch/arm/Kconfig | 2 ++ > arch/arm64/Kconfig | 2 ++ > arch/mips/Kconfig | 11 ----------- > arch/powerpc/Kconfig | 13 +------------ > arch/x86/Kconfig | 8 -------- > drivers/rapidio/Kconfig | 15 +++++++++++++++ > 6 files changed, 20 insertions(+), 31 deletions(-) > LGTM. Acked-by: Randy Dunlap # for the series thanks, -- ~Randy ``` ## Re: \[PATCH 3/6\] powerpc: factor out RapidIO Kconfig menu entry - From: Michael Ellerman \ - Date: 2018-07-31 09:45:48 - Message: https://ratatoskr.run/linuxppc-dev/2018/07/5346374.md ```text Alexei Colin [ref] writes: > The menu entry is now defined in the rapidio subtree. Also, re-order > the bus menu so tha the platform-specific RapidIO controller appears > after the entry for the RapidIO subsystem. > > Platforms with a PCI bus will be offered the RapidIO menu since they may > be want support for a RapidIO PCI device. Platforms without a PCI bus > that might include a RapidIO IP block will need to "select HAS_RAPIDIO" > in the platform-/machine-specific "config ARCH_*" Kconfig entry. > > Cc: Andrew Morton > Cc: John Paul Walters > Cc: > Cc: > Signed-off-by: Alexei Colin > --- > arch/powerpc/Kconfig | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) Looks good. Acked-by: Michael Ellerman (powerpc) cheers > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 25d005af0a5b..17ea8a5f90a0 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -993,16 +993,7 @@ source "drivers/pci/Kconfig" > > source "drivers/pcmcia/Kconfig" > > -config HAS_RAPIDIO > - bool > - default n > - > -config RAPIDIO > - tristate "RapidIO support" > - depends on HAS_RAPIDIO || PCI > - help > - If you say Y here, the kernel will include drivers and > - infrastructure code to support RapidIO interconnect devices. > +source "drivers/rapidio/Kconfig" > > config FSL_RIO > bool "Freescale Embedded SRIO Controller support" > @@ -1012,8 +1003,6 @@ config FSL_RIO > Include support for RapidIO controller on Freescale embedded > processors (MPC8548, MPC8641, etc). > > -source "drivers/rapidio/Kconfig" > - > endmenu > > config NONSTATIC_KERNEL > -- > 2.18.0 ``` ## Re: \[PATCH 0/6\] rapidio: move Kconfig menu definition to subsystem - From: Alex Bounine \ - Date: 2018-07-31 14:26:20 - Message: https://ratatoskr.run/linuxppc-dev/2018/07/5346577.md ```text Acked-by: Alexandre Bounine On 2018-07-30 06:50 PM, Alexei Colin wrote: > The top-level Kconfig entry for RapidIO subsystem is currently > duplicated in several architecture-specific Kconfig files. This set of > patches does two things: > > 1. Move the Kconfig menu definition into the RapidIO subsystem and > remove the duplicate definitions from arch Kconfig files. > > 2. Enable RapidIO Kconfig menu entry for arm and arm64 architectures, > where it was not enabled before. I tested that subsystem and drivers > build successfully for both architectures, and tested that the modules > load on a custom arm64 Qemu model. > > For all architectures, RapidIO menu should be offered when either: > (1) The platform has a PCI bus (which host a RapidIO module on the bus). > (2) The platform has a RapidIO IP block (connected to a system bus, e.g. > AXI on ARM). In this case, 'select HAS_RAPIDIO' should be added to the > 'config ARCH_*' menu entry for the SoCs that offer the IP block. > > Prior to this patchset, different architectures used different criteria: > * powerpc: (1) and (2) > * mips: (1) and (2) after recent commit into next that added (2): > https://www.linux-mips.org/archives/linux-mips/2018-07/msg00596.html > fc5d988878942e9b42a4de5204bdd452f3f1ce47 > 491ec1553e0075f345fbe476a93775eabcbc40b6 > * x86: (1) > * arm,arm64: none (RapidIO menus never offered) > > Responses to feedback from prior submission (thanks for the reviews!): > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593347.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593349.html > > Changelog: > * Moved Kconfig entry into RapidIO subsystem instead of duplicating > > In the current patchset, I took the approach of adding '|| PCI' to the > depends in the subsystem. I did try the alterantive approach mentioned > in the reviews for v1 of this patch, where the subsystem Kconfig does > not add a '|| PCI' and each per-architecture Kconfig has to add a > 'select HAS_RAPIDIO if PCI' and SoCs with IP blocks have to also add > 'select HAS_RAPIDIO'. This works too but requires each architecture's > Kconfig to add the line for RapidIO (whereas current approach does not > require that involvement) and also may create a false impression that > the dependency on PCI is strict. > > We appreciate the suggestion for also selecting the RapdiIO subsystem for > compilation with COMPILE_TEST, but hope to address it in a separate > patchset, localized to the subsystem, since it will need to change > depends on all drivers, not just on the top level, and since this > patch now spans multiple architectures. > > > Alexei Colin (6): > rapidio: define top Kconfig menu in driver subtree > x86: factor out RapidIO Kconfig menu > powerpc: factor out RapidIO Kconfig menu entry > mips: factor out RapidIO Kconfig entry > arm: enable RapidIO menu in Kconfig > arm64: enable RapidIO menu in Kconfig > > arch/arm/Kconfig | 2 ++ > arch/arm64/Kconfig | 2 ++ > arch/mips/Kconfig | 11 ----------- > arch/powerpc/Kconfig | 13 +------------ > arch/x86/Kconfig | 8 -------- > drivers/rapidio/Kconfig | 15 +++++++++++++++ > 6 files changed, 20 insertions(+), 31 deletions(-) > ```