[PATCH] powerpc: include setup.h header file to fix warnings

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2914d

2 messages, 2 authors, 2018-08-13 · open the first message on its own page

[PATCH] powerpc: include setup.h header file to fix warnings

From: Mathieu Malaterre <hidden>
Date: 2018-06-22 19:27:08

Make sure to include setup.h to provide the following prototypes:

- irqstack_early_init
- setup_power_save
- initialize_cache_info

Fix the following warnings (treated as error in W=1):

  arch/powerpc/kernel/setup_32.c:198:13: error: no previous prototype for ‘irqstack_early_init’ [-Werror=missing-prototypes]
  arch/powerpc/kernel/setup_32.c:238:13: error: no previous prototype for ‘setup_power_save’ [-Werror=missing-prototypes]
  arch/powerpc/kernel/setup_32.c:253:13: error: no previous prototype for ‘initialize_cache_info’ [-Werror=missing-prototypes]

Signed-off-by: Mathieu Malaterre <redacted>
---
 arch/powerpc/kernel/setup_32.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c
index 74457485574b..9827b6b3aaaa 100644
--- a/arch/powerpc/kernel/setup_32.c
+++ b/arch/powerpc/kernel/setup_32.c
@@ -41,6 +41,8 @@
 #include <asm/cpu_has_feature.h>
 #include <asm/asm-prototypes.h>
 
+#include "setup.h"
+
 #define DBG(fmt...)
 
 extern void bootx_init(unsigned long r4, unsigned long phys);
-- 
2.11.0

Re: powerpc: include setup.h header file to fix warnings

From: Michael Ellerman <hidden>
Date: 2018-08-13 11:23:51

On Fri, 2018-06-22 at 19:26:53 UTC, Mathieu Malaterre wrote:
Make sure to include setup.h to provide the following prototypes:

- irqstack_early_init
- setup_power_save
- initialize_cache_info

Fix the following warnings (treated as error in W=1):

  arch/powerpc/kernel/setup_32.c:198:13: error: no previous prototype for ���irqstack_early_init��� [-Werror=missing-prototypes]
  arch/powerpc/kernel/setup_32.c:238:13: error: no previous prototype for ���setup_power_save��� [-Werror=missing-prototypes]
  arch/powerpc/kernel/setup_32.c:253:13: error: no previous prototype for ���initialize_cache_info��� [-Werror=missing-prototypes]

Signed-off-by: Mathieu Malaterre <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/f2c6d0d1092e3da2bd36c768777e88

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help