[PATCH] powerpc/mm: Fix printing of process table address

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1618d

2 messages, 2 authors, 2022-03-09 · open the first message on its own page

[PATCH] powerpc/mm: Fix printing of process table address

From: Balbir Singh <bsingharora@gmail.com>
Date: 2018-03-28 03:09:43

New changes to %p cause the information printed at boot
about radix-mmu partition and process table opaque, if
we really want to protect those values, we should make
dmesg more secure using CONFIG_SECURITY_DMESG_RESTRICT

Before the patches:

radix-mmu: Partition table         (ptrval)
radix-mmu: Process table         (ptrval) and radix root for kernel:         (ptrval)

After the patches

radix-mmu: Partition table c0000000ffff0000
radix-mmu: Process table c0000000fe000000 and radix root for kernel: c0000000015a0000

Signed-off-by: Balbir Singh <bsingharora@gmail.com>
---
 arch/powerpc/mm/pgtable-radix.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/pgtable-radix.c b/arch/powerpc/mm/pgtable-radix.c
index 2e10a964e290..3f676e89c3a6 100644
--- a/arch/powerpc/mm/pgtable-radix.c
+++ b/arch/powerpc/mm/pgtable-radix.c
@@ -329,7 +329,8 @@ static void __init radix_init_pgtable(void)
 	 * physical address here.
 	 */
 	register_process_table(__pa(process_tb), 0, PRTB_SIZE_SHIFT - 12);
-	pr_info("Process table %p and radix root for kernel: %p\n", process_tb, init_mm.pgd);
+	pr_info("Process table %px and radix root for kernel: %px\n",
+			process_tb, init_mm.pgd);
 	asm volatile("ptesync" : : : "memory");
 	asm volatile(PPC_TLBIE_5(%0,%1,2,1,1) : :
 		     "r" (TLBIEL_INVAL_SET_LPID), "r" (0));
@@ -363,7 +364,7 @@ static void __init radix_init_partition_table(void)
 	mmu_partition_table_set_entry(0, dw0, 0);
 
 	pr_info("Initializing Radix MMU\n");
-	pr_info("Partition table %p\n", partition_tb);
+	pr_info("Partition table %px\n", partition_tb);
 }
 
 void __init radix_init_native(void)
-- 
2.13.6

Re: [PATCH] powerpc/mm: Fix printing of process table address

From: Christophe Leroy <hidden>
Date: 2022-03-09 09:09:53


Le 28/03/2018 à 05:09, Balbir Singh a écrit :
New changes to %p cause the information printed at boot
about radix-mmu partition and process table opaque, if
we really want to protect those values, we should make
dmesg more secure using CONFIG_SECURITY_DMESG_RESTRICT

Before the patches:

radix-mmu: Partition table         (ptrval)
radix-mmu: Process table         (ptrval) and radix root for kernel:         (ptrval)

After the patches

radix-mmu: Partition table c0000000ffff0000
radix-mmu: Process table c0000000fe000000 and radix root for kernel: c0000000015a0000

Signed-off-by: Balbir Singh <bsingharora@gmail.com>

This patch was superseded by ec5b705c4836 ("powerpc/mm/radix: remove 
useless kernel messages")
quoted hunk
---
  arch/powerpc/mm/pgtable-radix.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/pgtable-radix.c b/arch/powerpc/mm/pgtable-radix.c
index 2e10a964e290..3f676e89c3a6 100644
--- a/arch/powerpc/mm/pgtable-radix.c
+++ b/arch/powerpc/mm/pgtable-radix.c
@@ -329,7 +329,8 @@ static void __init radix_init_pgtable(void)
  	 * physical address here.
  	 */
  	register_process_table(__pa(process_tb), 0, PRTB_SIZE_SHIFT - 12);
-	pr_info("Process table %p and radix root for kernel: %p\n", process_tb, init_mm.pgd);
+	pr_info("Process table %px and radix root for kernel: %px\n",
+			process_tb, init_mm.pgd);
  	asm volatile("ptesync" : : : "memory");
  	asm volatile(PPC_TLBIE_5(%0,%1,2,1,1) : :
  		     "r" (TLBIEL_INVAL_SET_LPID), "r" (0));
@@ -363,7 +364,7 @@ static void __init radix_init_partition_table(void)
  	mmu_partition_table_set_entry(0, dw0, 0);
  
  	pr_info("Initializing Radix MMU\n");
-	pr_info("Partition table %p\n", partition_tb);
+	pr_info("Partition table %px\n", partition_tb);
  }
  
  void __init radix_init_native(void)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help