On Wed, Jan 31, 2018 at 10:03:46AM +0000, James Hogan wrote:

On Wed, Jan 31, 2018 at 10:37:30AM +0100, Gabriel Paubert wrote:

quoted

	Hi,

yesterday I recompiled the kernel on my late 2005 G4 PowerBook, and the
Wifi stopped working. After comparing the configuration is turns out
that a change to a Kconfig condition disabled SSB support which is
necessary for these chips.

The graph of configuration options is quite messy, and I'm not sure that
I fully understand it.

Nevertheless the following patch fixes the regression, but there might
be a better way to solve the problem.

If you pick up this trivial patch as is, you may add:

Signed-off-by: Gabriel Paubert <redacted>

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 71c7376..d189db6 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig

@@ -32,7 +32,7 @@ config SSB_BLOCKIO
 
 config SSB_PCIHOST_POSSIBLE
 	bool
-	depends on SSB && (PCI = y || PCI = SSB) && PCI_DRIVERS_LEGACY
+	depends on SSB && (PCI = y || PCI = SSB) && (PCI_DRIVERS_LEGACY || B43_SSB)
 	default y
 
 config SSB_PCIHOST

Yes, really sorry about that. There is a patch here:
https://patchwork.kernel.org/patch/10185397/

Ok, thanks, it's even better than my patch. I was not aware of that
patch: AFAIK it was not posted to one of the mailing I track, and it had
not percolated to Linus'tree which I pulled just before posting.

Sorry for the noise.

	Cheers,
	Gabriel