[PATCH kernel] powerpc/powernv/ioda: Finish removing explicit max window size check

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3153d

2 messages, 2 authors, 2018-01-22 · open the first message on its own page

[PATCH kernel] powerpc/powernv/ioda: Finish removing explicit max window size check

From: Alexey Kardashevskiy <hidden>
Date: 2018-01-18 02:51:39

9003a2498 removed checn from the DMA window pages allocator, however
the VFIO driver tests limits before doing so by calling
the get_table_size hook which was left behind; this fixes it.

Fixes: 9003a2498 "powerpc/powernv/ioda: Remove explicit max window size check"
Signed-off-by: Alexey Kardashevskiy <redacted>
---

It is properly tested now. Only affected folks for now are DPDK guys
with machines with non-power-of-two physical RAM amount.
---
 arch/powerpc/platforms/powernv/pci-ioda.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index b9146d5..1069f9c 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -2572,7 +2572,6 @@ static unsigned long pnv_pci_ioda2_get_table_size(__u32 page_shift,
 	unsigned long direct_table_size;
 
 	if (!levels || (levels > POWERNV_IOMMU_MAX_LEVELS) ||
-			(window_size > memory_hotplug_max()) ||
 			!is_power_of_2(window_size))
 		return 0;
 
-- 
2.11.0

Re: [kernel] powerpc/powernv/ioda: Finish removing explicit max window size check

From: Michael Ellerman <hidden>
Date: 2018-01-22 03:34:34

On Thu, 2018-01-18 at 02:51:03 UTC, Alexey Kardashevskiy wrote:
9003a2498 removed checn from the DMA window pages allocator, however
the VFIO driver tests limits before doing so by calling
the get_table_size hook which was left behind; this fixes it.

Fixes: 9003a2498 "powerpc/powernv/ioda: Remove explicit max window size check"
Signed-off-by: Alexey Kardashevskiy <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ae677ff02f2ddb0980953efd4afed1

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help