Thread (27 messages) 27 messages, 11 authors, 2018-01-30

Re: [PATCH 03/11] powerpc/64s: Simple RFI macro conversions

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2018-01-08 22:04:20
Also in: lkml

Paul Mackerras [off-list ref] writes:
On Mon, Jan 08, 2018 at 06:09:51PM +0100, Peter Zijlstra wrote:
quoted
On Tue, Jan 09, 2018 at 03:54:45AM +1100, Michael Ellerman wrote:
quoted
diff --git a/arch/powerpc/kvm/book3s_rmhandlers.S b/arch/powerpc/kvm/book3s_rmhandlers.S
index 42a4b237df5f..34a5adeff084 100644
--- a/arch/powerpc/kvm/book3s_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_rmhandlers.S
@@ -46,6 +46,9 @@
 
 #define FUNC(name)		name
 
+#define RFI_TO_KERNEL	RFI
+#define RFI_TO_GUEST	RFI
+
 .macro INTERRUPT_TRAMPOLINE intno
 
 .global kvmppc_trampoline_\intno
Leftovers? The previous patch seems to define all that in common
headers, why redefine here again?
Not leftovers - this is for the sake of 32-bit compiles.  There is
code in this file and in book3s_segment.S which gets used both for
32-bit and 64-bit kernels, and this is supplying a definition on
32-bit platforms.  Without this, 32-bit builds that have PR KVM
configured will fail.
Yep.

I was going to put all the RFI macros in a single header, and we could
then have the dummy versions in there as would the usual pattern. But at
this stage it would just complicate life for people doing distro
backports, so I'll do that as a cleanup once it's all merged.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help