From: Andrew F. Davis <hidden> Date: 2017-12-05 20:15:24
Hello all,
I was building a kernel for x86 and noticed Make still descended into
directories like drivers/gpu/drm/hisilicon, this seems kind of odd given
nothing will be built here. It looks to be due to some directories being
included in obj-y unconditionally instead of only when the relevant
CONFIG_ is set.
These patches are split by subsystem in-case, for some reason, a file in
a directory does need to be built, I believe I have checked for all
instances of this, but a quick review from some maintainers would be nice.
Thanks,
Andrew
Changes from v3:
- Removed patches already taken by maintainers
- Rebased on v4.15-rc1 (no changes needed)
Changes from v2:
- Removed patches that would not work
- Rebased on v4.11-rc1 (no changes needed)
Changes from v1:
- Removed patches already taken by maintainers
- Rebased on v4.10-rc1 (no changes needed)
Andrew F. Davis (5):
pwm: Only descend into pwm directory when CONFIG_PWM is set
amba: Only descend into amba directory when CONFIG_ARM_AMBA is set
NFC: Only descend into nfc directory when CONFIG_NFC is set
macintosh: Only descend into directory when CONFIG_MACINTOSH_DRIVERS
is set
auxdisplay: Only descend into directory when CONFIG_AUXDISPLAY is set
drivers/Makefile | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
--
2.15.0
From: Andrew F. Davis <hidden> Date: 2017-12-05 19:55:36
When CONFIG_AUXDISPLAY is not set make will still descend into the
auxdisplay directory but nothing will be built. This produces unneeded
build artifacts and messages in addition to slowing the build.
Fix this here.
Signed-off-by: Andrew F. Davis <redacted>
---
drivers/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Andrew F. Davis <hidden> Date: 2017-12-05 19:55:38
When CONFIG_ARM_AMBA is not set make will still descend into the amba
directory but nothing will be built. This produces unneeded build
artifacts and messages in addition to slowing the build. Fix this here.
Signed-off-by: Andrew F. Davis <redacted>
---
drivers/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -34,7 +34,7 @@ obj-$(CONFIG_SFI) += sfi/# PnP must come after ACPI since it will eventually need to check if acpi# was used and do nothing if soobj-$(CONFIG_PNP)+=pnp/-obj-y+=amba/+obj-$(CONFIG_ARM_AMBA)+=amba/obj-y+=clk/# Many drivers will want to use DMA so this has to be made available
From: Andrew F. Davis <hidden> Date: 2017-12-05 19:55:39
When CONFIG_NFC is not set make will still descend into the nfc
directory but nothing will be built. This produces unneeded build
artifacts and messages in addition to slowing the build. Fix this here.
Signed-off-by: Andrew F. Davis <redacted>
---
drivers/Makefile | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
From: Andrew F. Davis <hidden> Date: 2017-12-05 20:15:22
When CONFIG_MACINTOSH_DRIVERS is not set make will still descend into the
macintosh directory but nothing will be built. This produces unneeded
build artifacts and messages in addition to slowing the build.
Fix this here.
Signed-off-by: Andrew F. Davis <redacted>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Andrew F. Davis <hidden> Date: 2017-12-05 23:28:57
When CONFIG_PWM is not set make will still descend into the pwm
directory but nothing will be built. This produces unneeded build
artifacts and messages in addition to slowing the build. Fix this here.
Signed-off-by: Andrew F. Davis <redacted>
---
drivers/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -14,7 +14,7 @@ obj-$(CONFIG_GENERIC_PHY) += phy/# GPIO must come after pinctrl as gpios may need to mux pins etcobj-$(CONFIG_PINCTRL)+=pinctrl/obj-$(CONFIG_GPIOLIB)+=gpio/-obj-y+=pwm/+obj-$(CONFIG_PWM)+=pwm/obj-$(CONFIG_PCI)+=pci/obj-$(CONFIG_PCI_ENDPOINT)+=pci/endpoint/