[PATCH V2] powerpc/mm: Invalidate subpage_prot() system call on radix platforms

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3119d

2 messages, 2 authors, 2018-01-22 · open the first message on its own page

[PATCH V2] powerpc/mm: Invalidate subpage_prot() system call on radix platforms

From: Anshuman Khandual <hidden>
Date: 2017-12-04 05:49:31

Radix enabled platforms don't support subpage_prot() system calls. But
at present the system call goes through without an error and fails
later on while validating expected subpage accesses. Lets not allow
the system call on powerpc radix platforms to begin with to prevent
this confusion in user space.

Signed-off-by: Anshuman Khandual <redacted>
---
Changes in V2:

Now it returns -ENOENT error instead as per Michael Ellerman.

 arch/powerpc/mm/subpage-prot.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/mm/subpage-prot.c b/arch/powerpc/mm/subpage-prot.c
index 781532d..f14a07c 100644
--- a/arch/powerpc/mm/subpage-prot.c
+++ b/arch/powerpc/mm/subpage-prot.c
@@ -195,6 +195,9 @@ long sys_subpage_prot(unsigned long addr, unsigned long len, u32 __user *map)
 	unsigned long next, limit;
 	int err;
 
+	if (radix_enabled())
+		return -ENOENT;
+
 	/* Check parameters */
 	if ((addr & ~PAGE_MASK) || (len & ~PAGE_MASK) ||
 	    addr >= mm->task_size || len >= mm->task_size ||
-- 
1.8.3.1

Re: [V2] powerpc/mm: Invalidate subpage_prot() system call on radix platforms

From: Michael Ellerman <hidden>
Date: 2018-01-22 03:34:15

On Mon, 2017-12-04 at 05:49:22 UTC, Anshuman Khandual wrote:
Radix enabled platforms don't support subpage_prot() system calls. But
at present the system call goes through without an error and fails
later on while validating expected subpage accesses. Lets not allow
the system call on powerpc radix platforms to begin with to prevent
this confusion in user space.

Signed-off-by: Anshuman Khandual <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/5b2b80714796073ec9e196c7aeec59

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help