[PATCH] powerpc/xive: Properly use static keyword for inline function

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3121d

3 messages, 3 authors, 2018-01-22 · open the first message on its own page

[PATCH] powerpc/xive: Properly use static keyword for inline function

From: Mathieu Malaterre <hidden>
Date: 2017-12-26 13:00:40

Fix fatal warning during compilation:

In file included from arch/powerpc/xmon/xmon.c:54:0:
./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
 extern inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
                    ^

Signed-off-by: Mathieu Malaterre <redacted>
---
 arch/powerpc/include/asm/xive.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h
index 371fbebf1ec9..83dc2cc320a3 100644
--- a/arch/powerpc/include/asm/xive.h
+++ b/arch/powerpc/include/asm/xive.h
@@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; }
 static inline bool xive_spapr_init(void) { return false; }
 static inline bool xive_native_init(void) { return false; }
 static inline void xive_smp_probe(void) { }
-extern inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
+static inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
 static inline void xive_smp_setup_cpu(void) { }
 static inline void xive_smp_disable_cpu(void) { }
 static inline void xive_kexec_teardown_cpu(int secondary) { }
-- 
2.11.0

Re: [PATCH] powerpc/xive: Properly use static keyword for inline function

From: Cédric Le Goater <clg@kaod.org>
Date: 2018-01-15 09:51:17

On 12/26/2017 02:00 PM, Mathieu Malaterre wrote:
Fix fatal warning during compilation:

In file included from arch/powerpc/xmon/xmon.c:54:0:
./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
 extern inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
                    ^

Signed-off-by: Mathieu Malaterre <redacted>
Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C. 
quoted hunk
---
 arch/powerpc/include/asm/xive.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h
index 371fbebf1ec9..83dc2cc320a3 100644
--- a/arch/powerpc/include/asm/xive.h
+++ b/arch/powerpc/include/asm/xive.h
@@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; }
 static inline bool xive_spapr_init(void) { return false; }
 static inline bool xive_native_init(void) { return false; }
 static inline void xive_smp_probe(void) { }
-extern inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
+static inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
 static inline void xive_smp_setup_cpu(void) { }
 static inline void xive_smp_disable_cpu(void) { }
 static inline void xive_kexec_teardown_cpu(int secondary) { }

Re: powerpc/xive: Properly use static keyword for inline function

From: Michael Ellerman <hidden>
Date: 2018-01-22 03:34:21

On Tue, 2017-12-26 at 13:00:17 UTC, Mathieu Malaterre wrote:
Fix fatal warning during compilation:

In file included from arch/powerpc/xmon/xmon.c:54:0:
./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ���xive_smp_prepare_cpu��� [-Werror=missing-prototypes]
 extern inline int  xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
                    ^

Signed-off-by: Mathieu Malaterre <redacted>
Reviewed-by: C��dric Le Goater <clg@kaod.org>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/38833faa112c10dd6e3d888f8b53de

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help