Qoriq P5020 PowerPC board doesn't boot with the latest git version anymore

Hi All,

I tested the latest Git kernel version on my Varisys Cyrus Plus board 
(A-EON AmigaOne X5000) [1][2] with a Qoriq P5020 PowerPC CPU from NXP 
today. Unfortunately it doesn't boot anymore.

My Varisys Nemo board (A-EON AmigaOne X1000) [3], boots without any 
problems.

I bisected between the final kernel 4.14.0 and the git version from Mon 
Nov 13 21:14:07 2017 -0800.

a8a217c22116eff6c120d753c9934089fb229af0 is the first bad commit. [4]

Please find attached the git bisect log.

I tried to revert the bad commit I have found with bisect but 
unfortunately it doesn't work because of some conflicts.

git revert a8a217c22116eff6c120d753c9934089fb229af0

error: could not revert a8a217c... locking/core: Remove 
{read,spin,write}_can_lock()
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

I tried to revert the bad commit in the git version from Mon Nov 13 
21:14:07 2017 -0800 but unfortunately it doesn't work either.

error: could not revert a8a217c... locking/core: Remove 
{read,spin,write}_can_lock()
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Could you please help me to find the bug?

Thanks,
Christian


[1] http://www.amigaos.net/hardware/133/amigaone-x5000
[2] http://wiki.amiga.org/index.php?title=AmigaONE_X5000
[3] https://en.wikipedia.org/wiki/AmigaOne_X1000
[4] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a8a217c22116eff6c120d753c9934089fb229af0

Hi All,

The bug is definitely in the commit 
a8a217c22116eff6c120d753c9934089fb229af0. [1]

The kernel 4.14.0 boots without any problems on my Varisys Cyrus Plus 
board [2][3] and on my Varisys Nemo board [4]. I have patched the kernel 
4.14.0 source code with the bad commit I found with bisect last week.

After compiling, the kernel 4.14.0 doesn't boot anymore on my Varisys 
Cyrus Plus board [2][3].

Please help to find the bug in the bad commit. (Bisect log attached)

Thanks,
Christian


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a8a217c22116eff6c120d753c9934089fb229af0
[2] http://www.amigaos.net/hardware/133/amigaone-x5000
[3] http://wiki.amiga.org/index.php?title=AmigaONE_X5000
[4] https://en.wikipedia.org/wiki/AmigaOne_X1000

Hi All,

A little success. :-) I reverted the following files from the bad commit 
a8a217c22116eff6c120d753c9934089fb229af0 [1]:

arch/powerpc/include/asm/spinlock.h
kernel/locking/spinlock.c
include/linux/spinlock_up.h
include/linux/spinlock.h
include/linux/rwlock.h

After that I compiled the latest git kernel again. Then I was able to 
boot the latest git kernel on my Varisys Cyrus Plus board [2][3]. :-)

That means the bug is in one of these files.

Please help me to find the bug in these files above.

Thanks,
Christian


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a8a217c22116eff6c120d753c9934089fb229af0
[2] http://www.amigaos.net/hardware/133/amigaone-x5000
[3] http://wiki.amiga.org/index.php?title=AmigaONE_X5000

Hi All,

I created a patch for the git kernel today. (see attachment)
Without the patch, the latest git kernel doesn't boot on my Cyrus Plus 
board.

Cheers,
Christian


On 19 November 2017 at 5:57PM, Christian Zigotzky wrote:

Hi All,

A little success. :-) I reverted the following files from the bad 
commit a8a217c22116eff6c120d753c9934089fb229af0 [1]:

arch/powerpc/include/asm/spinlock.h
kernel/locking/spinlock.c
include/linux/spinlock_up.h
include/linux/spinlock.h
include/linux/rwlock.h

After that I compiled the latest git kernel again. Then I was able to 
boot the latest git kernel on my Varisys Cyrus Plus board [2][3]. :-)

That means the bug is in one of these files.

Please help me to find the bug in these files above.

Thanks,
Christian


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a8a217c22116eff6c120d753c9934089fb229af0
[2] http://www.amigaos.net/hardware/133/amigaone-x5000
[3] http://wiki.amiga.org/index.php?title=AmigaONE_X5000

Christian Zigotzky [off-list ref] writes:

Hi All,

I created a patch for the git kernel today. (see attachment)
Without the patch, the latest git kernel doesn't boot on my Cyrus Plus 
board.

Hi Christian,

This doesn't make much sense.

Are you running any out of tree drivers or patches on this machine? Or
just 100% upstream.

I have a freescale p5020ds machine, but I don't have this Cyrus Plus
board.

What kernel config are you using, can you attach it?

When you say it "doesn't boot" what happens exactly? Do you see any
output at all?

cheers

On 22 November 2017 at 12:28PM, Michael Ellerman wrote:

Christian Zigotzky [off-list ref] writes:

quoted

Hi All,

I created a patch for the git kernel today. (see attachment)
Without the patch, the latest git kernel doesn't boot on my Cyrus Plus
board.

Hi Christian,

This doesn't make much sense.

Are you running any out of tree drivers or patches on this machine? Or
just 100% upstream.

I have a freescale p5020ds machine, but I don't have this Cyrus Plus
board.

What kernel config are you using, can you attach it?

When you say it "doesn't boot" what happens exactly? Do you see any
output at all?

cheers

Hi Michael,

No, I am not running any out of tree drivers or patches. The Cyrus board 
is fully integrated in the tree. [1] No, I don't see any output.

Please find attached the kernel config.

Thanks,
Christian

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c383ee84e1d575b09d167185d15df24bde25eb15

Hi All,

I compiled the latest git kernel today. Unfortunately my Varisys Cyrus 
Plus board still doesn't boot with the latest git kernel.

After that I patched the kernel source code with the spinlock patch and 
compiled the kernel again. With the spinlock patch, the latest git 
kernel boots without any problems.

Please find attached the spinlock patch.

Cheers,
Christian


On 20 November 2017 at 00:34AM, Christian Zigotzky wrote:

Hi All,

I created a patch for the git kernel today. (see attachment)
Without the patch, the latest git kernel doesn't boot on my Cyrus Plus 
board.

Cheers,
Christian


On 19 November 2017 at 5:57PM, Christian Zigotzky wrote:

quoted

Hi All,

A little success. :-) I reverted the following files from the bad 
commit a8a217c22116eff6c120d753c9934089fb229af0 [1]:

arch/powerpc/include/asm/spinlock.h
kernel/locking/spinlock.c
include/linux/spinlock_up.h
include/linux/spinlock.h
include/linux/rwlock.h

After that I compiled the latest git kernel again. Then I was able to 
boot the latest git kernel on my Varisys Cyrus Plus board [2][3]. :-)

That means the bug is in one of these files.

Please help me to find the bug in these files above.

Thanks,
Christian


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a8a217c22116eff6c120d753c9934089fb229af0
[2] http://www.amigaos.net/hardware/133/amigaone-x5000
[3] http://wiki.amiga.org/index.php?title=AmigaONE_X5000

Christian Zigotzky [off-list ref] writes:

Hi All,

I compiled the latest git kernel today. Unfortunately my Varisys Cyrus 
Plus board still doesn't boot with the latest git kernel.

After that I patched the kernel source code with the spinlock patch and 
compiled the kernel again. With the spinlock patch, the latest git 
kernel boots without any problems.

Please find attached the spinlock patch.

Can you remove the patch, and then build your kernel with
CONFIG_PREEMPT=n.

cheers

Hi Michael,

Success! :-)

I disabled PREEMPT in the kernel config and I removed the spinlock patch 
today. After that I compiled the RC1 again. With 'CONFIG_PREEMPT=n' and 
without the spinlock patch, the RC1 boots on my Qoriq P5020 PowerPC 
board without any problems.

Many thanks for your help. :-)

Cheers,
Christian


On 28 November 2017 at 11:37AM, Michael Ellerman wrote:

Christian Zigotzky [off-list ref] writes:

quoted

Hi All,

I compiled the latest git kernel today. Unfortunately my Varisys Cyrus
Plus board still doesn't boot with the latest git kernel.

After that I patched the kernel source code with the spinlock patch and
compiled the kernel again. With the spinlock patch, the latest git
kernel boots without any problems.

Please find attached the spinlock patch.

Can you remove the patch, and then build your kernel with
CONFIG_PREEMPT=n.

cheers