# Re: \[PATCH kernel 3/5\] powerpc/eeh: Remove unnecessary pointer to phb from eeh\_dev

- From: Michael Ellerman \<mpe@ellerman.id.au\>
- Date: 2017-08-28 06:25:10 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2017/08/9499364
- Thread: https://ratatoskr.run/linuxppc-dev/2017/08/9499275/t.md

```text
Alexey Kardashevskiy [ref] writes:

> The eeh_dev struct already holds a pointer to pci_dn which it does not
> exist without and pci_dn itself holds the very same pointer so just
> use it.
>
> Signed-off-by: Alexey Kardashevskiy <redacted>
> ---
>  arch/powerpc/include/asm/eeh.h               |  1 -
>  arch/powerpc/kernel/eeh.c                    |  7 +++----
>  arch/powerpc/kernel/eeh_dev.c                |  2 --
>  arch/powerpc/kernel/eeh_driver.c             |  2 +-
>  arch/powerpc/kernel/eeh_pe.c                 | 24 +++++++++++++---------=
--
>  arch/powerpc/platforms/powernv/eeh-powernv.c |  5 ++---

Doesn't build ?

  arch/powerpc/platforms/pseries/eeh_pseries.c: In function =E2=80=98pserie=
s_eeh_probe=E2=80=99:
  arch/powerpc/platforms/pseries/eeh_pseries.c:250:15: error: =E2=80=98stru=
ct eeh_dev=E2=80=99 has no member named =E2=80=98phb=E2=80=99
  pe.phb =3D edev->phb;
               ^~

cheers
```