should "linux-phandle" be "linux,phandle"?

2 messages, 2 authors, 2017-08-16 · open the first message on its own page

should "linux-phandle" be "linux,phandle"?

From: <hidden>
Date: 2017-08-15 13:48:01

   pedantic nitpickery but, in arch/powerpc/kernel/prom_init.c, line 2426,
should that diagnostic message print "<linux,phandle>" and not  
"<linux-phandle>"?

rday

Re: should "linux-phandle" be "linux,phandle"?

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-08-16 06:11:37

rpjday@crashcourse.ca writes:
   pedantic nitpickery but, in arch/powerpc/kernel/prom_init.c, line 2426,
should that diagnostic message print "<linux,phandle>" and not  
"<linux-phandle>"?
Yeah I guess.

AFAICS it can't happen though, we created the "linux,phandle" string
just prior, around line 2488.

So it could just be:

		soff = dt_find_string("linux,phandle");
		if (soff == 0)
			prom_printf("WARNING: Wat?!\n");
		else
			...

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help