# Re: block/ps3vram: Check return of ps3vram\_cache\_init

- From: SF Markus Elfring \<hidden\>
- Date: 2017-08-08 12:53:23 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2017/08/9498981
- Thread: https://ratatoskr.run/linuxppc-dev/2017/08/9498930/t.md

```text
> @@ -741,7 +741,11 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev)
>  		goto out_unmap_reports;
>  	}
>  
> -	ps3vram_cache_init(dev);
> +	error = ps3vram_cache_init(dev);
> +	if (error < 0) {
> +		goto out_unmap_reports;
> +	}
> +
>  	ps3vram_proc_init(dev);
>  
>  	queue = blk_alloc_queue(GFP_KERNEL);

I pointed a few development concerns out.
https://patchwork.ozlabs.org/patch/798575/

Will the commit subject “block/ps3vram: Check return value of ps3vram_cache_init()”
be more appropriate?

Regards,
Markus
```