# \[PATCH 1/2\] soc/fsl/qe: Fix a potential NULL pointer dereference in an error handling path

- Subsystems: FREESCALE QUICC ENGINE LIBRARY, FREESCALE SOC DRIVERS, THE REST
- Maintainers: Qiang Zhao, Christophe Leroy, Linus Torvalds
- List: linuxppc-dev
- 1 message, 1 author
- Page: https://ratatoskr.run/linuxppc-dev/2017/08/5071555/t

## \[PATCH 1/2\] soc/fsl/qe: Fix a potential NULL pointer dereference in an error handling path

- From: Christophe JAILLET \<hidden\>
- Date: 2017-08-20 15:53:22 
- Message: https://ratatoskr.run/linuxppc-dev/2017/08/5071555.md

```text
If 'of_find_device_by_node()' fails at line 153, a NULL pointer
dereference (pdev) will occur in the error handling path.

Just remove the 'devm_iounmap()' call from the error handling path. The
corresponding is managed, there is no need to release explicitly here.

Fixes: 35ef1c20fdb2 ("fsl/qe: Add QE TDM lib")
Signed-off-by: Christophe JAILLET <redacted>
---
This patch is only a guess that sounds logical to me.

I propose to remove this 'devm_iounmap' mainly because of its name (if it
is managed, why should be manually handle it here ?)
---
 drivers/soc/fsl/qe/qe_tdm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c
index f744c214f680..6b9647fee512 100644
--- a/drivers/soc/fsl/qe/qe_tdm.c
+++ b/drivers/soc/fsl/qe/qe_tdm.c
@@ -174,7 +174,6 @@ int ucc_of_parse_tdm(struct device_node *np, struct ucc_tdm *utdm,
 	return ret;
 
 err_miss_siram_property:
-	devm_iounmap(&pdev->dev, utdm->si_regs);
 	return ret;
 }
 EXPORT_SYMBOL(ucc_of_parse_tdm);
-- 
2.11.0
```