This is a port on kernel 4.13 of the work done by Peter Zijlstra to
handle page fault without holding the mm semaphore [1].
The idea is to try to handle user space page faults without holding the
mmap_sem. This should allow better concurrency for massively threaded
process since the page fault handler will not wait for other threads memory
layout change to be done, assuming that this change is done in another part
of the process's memory space. This type page fault is named speculative
page fault. If the speculative page fault fails because of a concurrency is
detected or because underlying PMD or PTE tables are not yet allocating, it
is failing its processing and a classic page fault is then tried.
The speculative page fault (SPF) has to look for the VMA matching the fault
address without holding the mmap_sem, so the VMA list is now managed using
SRCU allowing lockless walking. The only impact would be the deferred file
derefencing in the case of a file mapping, since the file pointer is
released once the SRCU cleaning is done. This patch relies on the change
done recently by Paul McKenney in SRCU which now runs a callback per CPU
instead of per SRCU structure [1].
The VMA's attributes checked during the speculative page fault processing
have to be protected against parallel changes. This is done by using a per
VMA sequence lock. This sequence lock allows the speculative page fault
handler to fast check for parallel changes in progress and to abort the
speculative page fault in that case.
Once the VMA is found, the speculative page fault handler would check for
the VMA's attributes to verify that the page fault has to be handled
correctly or not. Thus the VMA is protected through a sequence lock which
allows fast detection of concurrent VMA changes. If such a change is
detected, the speculative page fault is aborted and a *classic* page fault
is tried. VMA sequence locks are added when VMA attributes which are
checked during the page fault are modified.
When the PTE is fetched, the VMA is checked to see if it has been changed,
so once the page table is locked, the VMA is valid, so any other changes
leading to touching this PTE will need to lock the page table, so no
parallel change is possible at this time.
Compared to the Peter's initial work, this series introduces a spin_trylock
when dealing with speculative page fault. This is required to avoid dead
lock when handling a page fault while a TLB invalidate is requested by an
other CPU holding the PTE. Another change due to a lock dependency issue
with mapping->i_mmap_rwsem.
This series builds on top of v4.13-rc4 and is functional on x86 and
PowerPC.
Tests have been made using a large commercial in-memory database on a
PowerPC system with 752 CPUs. The results are very encouraging since the
loading of the 2TB database was faster by 14% with the speculative page
fault.
Using ebizzy test [3], which spreads a lot of threads, the result are good
when running on both a large or a small system. When using kernbench, the
result are quite similar which expected as not so much multithreaded
processes are involved. But there is no performance degradation neither
which is good.
------------------
Benchmarks results
Note these test have been made on top of 4.13-rc3 with the following patch
from Paul McKenney applied:
"srcu: Provide ordering for CPU not involved in grace period" [5]
Ebizzy:
-------
The test is counting the number of records per second it can manage, the
higher is the best. I run it like this 'ebizzy -mTRp'. To get consistent
result I repeated the test 100 times and measure the average result, mean
deviation and max.
- 16 CPUs x86 VM
Records/s 4.13-rc3 4.13-rc3-spf
Average 11455.92 45803.64
Mean deviation 509.34 848.19
Max 13997 49824
- 80 CPUs Power 8 node:
Records/s 4.13-rc3 4.13-rc3-spf
Average 33848.76 63427.62
Mean deviation 684.48 1618.84
Max 36235 70401
Kernbench:
----------
This test is building a 4.12 kernel using platform default config. The
build has been run 5 times each time.
- 16 CPUs x86 VM
Average Half load -j 7 Run (std deviation)
4.13.0-rc3 4.13.0-rc3-spf
Elapsed Time 166.668 (0.462299) 167.55 (0.432724)
User Time 1083.11 (2.89018) 1083.76 (2.17015)
System Time 202.982 (0.984058) 210.364 (0.890382)
Percent CPU 771.2 (0.83666) 771.8 (1.09545)
Context Switches 46789 (519.558) 67602.4 (365.929)
Sleeps 83870.8 (836.392) 84269.4 (457.962)
Average Optimal load -j 16 Run (std deviation)
4.13.0-rc3 4.13.0-rc3-spf
Elapsed Time 85.002 (0.298111) 85.406 (0.506784)
User Time 1033.25 (52.6037) 1034.63 (51.8167)
System Time 185.46 (18.4826) 191.75 (19.6379)
Percent CPU 1062.6 (307.181) 1063.9 (307.948)
Context Switches 67423.3 (21762.7) 91316.1 (25004.4)
Sleeps 89393.6 (5860.2) 89489.9 (5563.54)
The elapsed time is in the same order, a bit larger in the case of the spf
release, but that seems to be in the error margin.
- 80 CPUs Power 8 node:
Average Half load -j 40 Run (std deviation)
4.13.0-rc3 4.13.0-rc3-spf
Elapsed Time 116.422 (0.604707) 116.898 (1.00981)
User Time 4410.13 (23.4272) 4393.49 (22.6739)
System Time 130.128 (0.567468) 132.16 (0.840238)
Percent CPU 3899.2 (13.9535) 3871 (17.6777)
Context Switches 72699.8 (585.077) 73281.4 (516.003)
Sleeps 160396 (1248.34) 161801 (522.71)
Average Optimal load -j 80 Run (std deviation)
4.13.0-rc3 4.13.0-rc3-spf
Elapsed Time 111.216 (0.826698) 110.442 (0.846505)
User Time 5911.85 (1583.04) 5932.14 (1622.02)
System Time 164.799 (36.5712) 168.29 (38.0891)
Percent CPU 5371.9 (1552.74) 5410.2 (1623.17)
Context Switches 117770 (47512.1) 130131 (59927.8)
Sleeps 161619 (2210.47) 163442 (2349.71)
Here the elapsed time is a bit shorter using the spf release, but again we
stay in the error margin. It has to be noted that this system is not
correctly balanced on the NUMA point of view as all the available memory is
attached to one core.
------------------------
Changes since RFC V5 [6]
- Port to 4.13 kernel
- Merging patch fixing lock dependency into the original patch
- Replace the 2 parameters of vma_has_changed() with the vmf pointer
- In patch 7, don't call __do_fault() in the speculative path as it may
want to unlock the mmap_sem.
- In patch 11-12, don't check for vma boundaries when
page_add_new_anon_rmap() is called during the spf path and protect against
anon_vma pointer's update.
- In patch 13-16, add performance events to report number of successful
and failed speculative events.
[1] http://linux-kernel.2935.n7.nabble.com/RFC-PATCH-0-6-Another-go-at-speculative-page-faults-tt965642.html#none
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da915ad5cf25b5f5d358dd3670c3378d8ae8c03e
[3] http://ebizzy.sourceforge.net/
[4] http://ck.kolivas.org/apps/kernbench/kernbench-0.50/
[5] https://lkml.org/lkml/2017/7/24/829
[6] https://lwn.net/Articles/725607/
Laurent Dufour (10):
mm: Introduce pte_spinlock for FAULT_FLAG_SPECULATIVE
mm: Protect VMA modifications using VMA sequence count
mm: Try spin lock in speculative path
powerpc/mm: Add speculative page fault
mm: Introduce __page_add_new_anon_rmap()
mm: Protect SPF handler against anon_vma changes
perf: Add a speculative page fault sw events
x86/mm: Add support for SPF events
powerpc/mm: Add support for SPF events
perf tools: Add support for SPF events
Peter Zijlstra (6):
mm: Dont assume page-table invariance during faults
mm: Prepare for FAULT_FLAG_SPECULATIVE
mm: VMA sequence count
mm: RCU free VMAs
mm: Provide speculative fault infrastructure
x86/mm: Add speculative pagefault handling
arch/powerpc/mm/fault.c | 30 +++-
arch/x86/mm/fault.c | 18 ++
fs/proc/task_mmu.c | 2 +
include/linux/mm.h | 4 +
include/linux/mm_types.h | 3 +
include/linux/rmap.h | 12 +-
include/uapi/linux/perf_event.h | 2 +
kernel/fork.c | 1 +
mm/init-mm.c | 1 +
mm/internal.h | 19 +++
mm/khugepaged.c | 3 +
mm/madvise.c | 4 +
mm/memory.c | 302 ++++++++++++++++++++++++++++------
mm/mempolicy.c | 10 +-
mm/mlock.c | 9 +-
mm/mmap.c | 123 ++++++++++----
mm/mprotect.c | 2 +
mm/mremap.c | 7 +
mm/rmap.c | 5 +-
tools/include/uapi/linux/perf_event.h | 2 +
tools/perf/util/evsel.c | 2 +
tools/perf/util/parse-events.c | 8 +
tools/perf/util/parse-events.l | 2 +
tools/perf/util/python.c | 2 +
24 files changed, 484 insertions(+), 89 deletions(-)
--
2.7.4
From: Peter Zijlstra <peterz@infradead.org>
One of the side effects of speculating on faults (without holding
mmap_sem) is that we can race with free_pgtables() and therefore we
cannot assume the page-tables will stick around.
Remove the reliance on the pte pointer.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
mm/memory.c | 27 ---------------------------
1 file changed, 27 deletions(-)
When handling page fault without holding the mmap_sem the fetch of the
pte lock pointer and the locking will have to be done while ensuring
that the VMA is not touched in our back.
So move the fetch and locking operations in a dedicated function.
Signed-off-by: Laurent Dufour <redacted>
---
mm/memory.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
From: Peter Zijlstra <peterz@infradead.org>
When speculating faults (without holding mmap_sem) we need to validate
that the vma against which we loaded pages is still valid when we're
ready to install the new PTE.
Therefore, replace the pte_offset_map_lock() calls that (re)take the
PTL with pte_map_lock() which can fail in case we find the VMA changed
since we started the fault.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
[Port to 4.12 kernel]
[Remove the comment about the fault_env structure which has been
implemented as the vm_fault structure in the kernel]
Signed-off-by: Laurent Dufour <redacted>
---
include/linux/mm.h | 1 +
mm/memory.c | 55 ++++++++++++++++++++++++++++++++++++++----------------
2 files changed, 40 insertions(+), 16 deletions(-)
@@ -286,6 +286,7 @@ extern pgprot_t protection_map[16];#define FAULT_FLAG_USER 0x40 /* The fault originated in userspace */#define FAULT_FLAG_REMOTE 0x80 /* faulting for non current tsk/mm */#define FAULT_FLAG_INSTRUCTION 0x100 /* The fault was during an instruction fetch */+#define FAULT_FLAG_SPECULATIVE 0x200 /* Speculative fault, not holding mmap_sem */#define FAULT_FLAG_TRACE \{FAULT_FLAG_WRITE,"WRITE"},\
From: Peter Zijlstra <peterz@infradead.org>
Manage the VMAs with SRCU such that we can do a lockless VMA lookup.
We put the fput(vma->vm_file) in the SRCU callback, this keeps files
valid during speculative faults, this is possible due to the delayed
fput work by Al Viro -- do we need srcu_barrier() in unmount
someplace?
We guard the mm_rb tree with a seqlock (this could be a seqcount but
we'd have to disable preemption around the write side in order to make
the retry loop in __read_seqcount_begin() work) such that we can know
if the rb tree walk was correct. We cannot trust the restult of a
lockless tree walk in the face of concurrent tree rotations; although
we can trust on the termination of such walks -- tree rotations
guarantee the end result is a tree again after all.
Furthermore, we rely on the WMB implied by the
write_seqlock/count_begin() to separate the VMA initialization and the
publishing stores, analogous to the RELEASE in rcu_assign_pointer().
We also rely on the RMB from read_seqretry() to separate the vma load
from further loads like the smp_read_barrier_depends() in regular
RCU.
We must not touch the vmacache while doing SRCU lookups as that is not
properly serialized against changes. We update gap information after
publishing the VMA, but A) we don't use that and B) the seqlock
read side would fix that anyhow.
We clear vma->vm_rb for nodes removed from the vma tree such that we
can easily detect such 'dead' nodes, we rely on the WMB from
write_sequnlock() to separate the tree removal and clearing the node.
Provide find_vma_srcu() which wraps the required magic.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
[Remove the warnings in description about the SRCU global lock which
has been removed now]
[Rename vma_is_dead() to vma_has_changed()]
[Pass vm_fault structure pointer instead of 2 arguments to
vmf_has_changed() ]
Signed-off-by: Laurent Dufour <redacted>
---
include/linux/mm_types.h | 2 +
kernel/fork.c | 1 +
mm/init-mm.c | 1 +
mm/internal.h | 19 +++++++++
mm/mmap.c | 100 +++++++++++++++++++++++++++++++++++------------
5 files changed, 97 insertions(+), 26 deletions(-)
@@ -900,15 +928,13 @@ int __vma_adjust(struct vm_area_struct *vma, unsigned long start,}if(remove_next){-if(file){+if(file)uprobe_munmap(next,next->vm_start,next->vm_end);-fput(file);-}if(next->anon_vma)anon_vma_merge(vma,next);mm->map_count--;mpol_put(vma_policy(next));-kmem_cache_free(vm_area_cachep,next);+free_vma(next);write_seqcount_end(&next->vm_sequence);/**Inmprotect'scase6(seecommentsonvma_merge),
@@ -2129,15 +2155,10 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len,EXPORT_SYMBOL(get_unmapped_area);/* Look up the first VMA which satisfies addr < vm_end, NULL if none. */-structvm_area_struct*find_vma(structmm_struct*mm,unsignedlongaddr)+staticstructvm_area_struct*__find_vma(structmm_struct*mm,unsignedlongaddr){structrb_node*rb_node;-structvm_area_struct*vma;--/* Check the cache first. */-vma=vmacache_find(mm,addr);-if(likely(vma))-returnvma;+structvm_area_struct*vma=NULL;rb_node=mm->mm_rb.rb_node;
@@ -2155,13 +2176,40 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)rb_node=rb_node->rb_right;}+returnvma;+}++structvm_area_struct*find_vma(structmm_struct*mm,unsignedlongaddr)+{+structvm_area_struct*vma;++/* Check the cache first. */+vma=vmacache_find(mm,addr);+if(likely(vma))+returnvma;++vma=__find_vma(mm,addr);if(vma)vmacache_update(addr,vma);returnvma;}-EXPORT_SYMBOL(find_vma);+structvm_area_struct*find_vma_srcu(structmm_struct*mm,unsignedlongaddr)+{+structvm_area_struct*vma;+unsignedintseq;++WARN_ON_ONCE(!srcu_read_lock_held(&vma_srcu));++do{+seq=read_seqbegin(&mm->mm_seq);+vma=__find_vma(mm,addr);+}while(read_seqretry(&mm->mm_seq,seq));++returnvma;+}+/**Sameasfind_vma,butalsoreturnapointertothepreviousVMAin*pprev.*/
From: Peter Zijlstra <peterz@infradead.org>
Provide infrastructure to do a speculative fault (not holding
mmap_sem).
The not holding of mmap_sem means we can race against VMA
change/removal and page-table destruction. We use the SRCU VMA freeing
to keep the VMA around. We use the VMA seqcount to detect change
(including umapping / page-table deletion) and we use gup_fast() style
page-table walking to deal with page-table races.
Once we've obtained the page and are ready to update the PTE, we
validate if the state we started the fault with is still valid, if
not, we'll fail the fault with VM_FAULT_RETRY, otherwise we update the
PTE and we're done.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
[Manage the newly introduced pte_spinlock() for speculative page
fault to fail if the VMA is touched in our back]
[Rename vma_is_dead() to vma_has_changed()]
[Call p4d_alloc() as it is safe since pgd is valid]
[Call pud_alloc() as it is safe since p4d is valid]
[Set fe.sequence in __handle_mm_fault()]
[Abort speculative path when handle_userfault() has to be called]
[Add additional VMA's flags checks in handle_speculative_fault()]
[Clear FAULT_FLAG_ALLOW_RETRY in handle_speculative_fault()]
[Don't set vmf->pte and vmf->ptl if pte_map_lock() failed]
[Remove warning comment about waiting for !seq&1 since we don't want
to wait]
[Remove warning about no huge page support, mention it explictly]
[Don't call do_fault() in the speculative path as __do_fault() calls
vma->vm_ops->fault() which may want to release mmap_sem]
[Only vm_fault pointer argument for vma_has_changed()]
Signed-off-by: Laurent Dufour <redacted>
---
include/linux/mm.h | 3 +
mm/memory.c | 183 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 183 insertions(+), 3 deletions(-)
@@ -315,6 +315,7 @@ struct vm_fault {gfp_tgfp_mask;/* gfp mask to be used for allocations */pgoff_tpgoff;/* Logical page offset based on vma */unsignedlongaddress;/* Faulting virtual address */+unsignedintsequence;pmd_t*pmd;/* Pointer to pmd entry matching*the'address'*/pud_t*pud;/* Pointer to pud entry matching
@@ -1286,6 +1287,8 @@ int invalidate_inode_page(struct page *page);#ifdef CONFIG_MMUexterninthandle_mm_fault(structvm_area_struct*vma,unsignedlongaddress,unsignedintflags);+externinthandle_speculative_fault(structmm_struct*mm,+unsignedlongaddress,unsignedintflags);externintfixup_user_fault(structtask_struct*tsk,structmm_struct*mm,unsignedlongaddress,unsignedintfault_flags,bool*unlocked);
@@ -2245,15 +2245,69 @@ static inline void wp_page_reuse(struct vm_fault *vmf)staticboolpte_spinlock(structvm_fault*vmf){+boolret=false;++/* Check if vma is still valid */+if(!(vmf->flags&FAULT_FLAG_SPECULATIVE)){+vmf->ptl=pte_lockptr(vmf->vma->vm_mm,vmf->pmd);+spin_lock(vmf->ptl);+returntrue;+}++local_irq_disable();+if(vma_has_changed(vmf))+gotoout;+vmf->ptl=pte_lockptr(vmf->vma->vm_mm,vmf->pmd);spin_lock(vmf->ptl);-returntrue;++if(vma_has_changed(vmf)){+spin_unlock(vmf->ptl);+gotoout;+}++ret=true;+out:+local_irq_enable();+returnret;}staticboolpte_map_lock(structvm_fault*vmf){-vmf->pte=pte_offset_map_lock(vmf->vma->vm_mm,vmf->pmd,vmf->address,&vmf->ptl);-returntrue;+boolret=false;+pte_t*pte;+spinlock_t*ptl;++if(!(vmf->flags&FAULT_FLAG_SPECULATIVE)){+vmf->pte=pte_offset_map_lock(vmf->vma->vm_mm,vmf->pmd,+vmf->address,&vmf->ptl);+returntrue;+}++/*+*Thefirstvma_has_changed()guaranteesthepage-tablesarestill+*valid,havingIRQsdisabledensurestheystayaround,hencethe+*secondvma_has_changed()tomakesuretheyarestillvalidonce+*we'vegotthelock.Afterthataconcurrentzap_pte_range()will+*blockonthePTLandthuswe'resafe.+*/+local_irq_disable();+if(vma_has_changed(vmf))+gotoout;++pte=pte_offset_map_lock(vmf->vma->vm_mm,vmf->pmd,+vmf->address,&ptl);+if(vma_has_changed(vmf)){+pte_unmap_unlock(pte,ptl);+gotoout;+}++vmf->pte=pte;+vmf->ptl=ptl;+ret=true;+out:+local_irq_enable();+returnret;}/*
@@ -2872,6 +2926,10 @@ static int do_anonymous_page(struct vm_fault *vmf)if(vma->vm_flags&VM_SHARED)returnVM_FAULT_SIGBUS;+/* Can't call userland page fault handler in the speculative path */+if(vmf->flags&FAULT_FLAG_SPECULATIVE&&userfaultfd_missing(vma))+returnVM_FAULT_RETRY;+/**Usepte_alloc()insteadofpte_alloc_map().Wecan'trun*pte_offset_map()onpmdswhereahugepmdmightbecreated
@@ -3707,6 +3765,8 @@ static int handle_pte_fault(struct vm_fault *vmf)if(!vmf->pte){if(vma_is_anonymous(vmf->vma))returndo_anonymous_page(vmf);+elseif(vmf->flags&FAULT_FLAG_SPECULATIVE)+returnVM_FAULT_RETRY;elsereturndo_fault(vmf);}
@@ -3802,6 +3862,7 @@ static int __handle_mm_fault(struct vm_area_struct *vma, unsigned long address,vmf.pmd=pmd_alloc(mm,vmf.pud,address);if(!vmf.pmd)returnVM_FAULT_OOM;+vmf.sequence=raw_read_seqcount(&vma->vm_sequence);if(pmd_none(*vmf.pmd)&&transparent_hugepage_enabled(vma)){ret=create_huge_pmd(&vmf);if(!(ret&VM_FAULT_FALLBACK))
@@ -3829,6 +3890,122 @@ static int __handle_mm_fault(struct vm_area_struct *vma, unsigned long address,returnhandle_pte_fault(&vmf);}+inthandle_speculative_fault(structmm_struct*mm,unsignedlongaddress,+unsignedintflags)+{+structvm_faultvmf={+.address=address,+};+pgd_t*pgd;+p4d_t*p4d;+pud_t*pud;+pmd_t*pmd;+intdead,seq,idx,ret=VM_FAULT_RETRY;+structvm_area_struct*vma;++/* Clear flags that may lead to release the mmap_sem to retry */+flags&=~(FAULT_FLAG_ALLOW_RETRY|FAULT_FLAG_KILLABLE);+flags|=FAULT_FLAG_SPECULATIVE;++idx=srcu_read_lock(&vma_srcu);+vma=find_vma_srcu(mm,address);+if(!vma)+gotounlock;++/*+*ValidatetheVMAfoundbythelocklesslookup.+*/+dead=RB_EMPTY_NODE(&vma->vm_rb);+seq=raw_read_seqcount(&vma->vm_sequence);/* rmb <-> seqlock,vma_rb_erase() */+if((seq&1)||dead)+gotounlock;++/*+*Weneedtore-validatetheVMAaftercheckingthebounds,otherwise+*wemighthaveafalsepositiveonthebounds.+*/+if(address<vma->vm_start||vma->vm_end<=address)+gotounlock;++/*+*Hugepagesarenotyetsupported.+*/+if(unlikely(is_vm_hugetlb_page(vma)))+gotounlock;++/*+*Thethreefollowingchecksarecopiedfromaccess_errorfrom+*arch/x86/mm/fault.c+*/+if(!arch_vma_access_permitted(vma,flags&FAULT_FLAG_WRITE,+flags&FAULT_FLAG_INSTRUCTION,+flags&FAULT_FLAG_REMOTE))+gotounlock;++/* This is one is required to check that the VMA has write access set */+if(flags&FAULT_FLAG_WRITE){+if(unlikely(!(vma->vm_flags&VM_WRITE)))+gotounlock;+}else{+if(unlikely(!(vma->vm_flags&(VM_READ|VM_EXEC|VM_WRITE))))+gotounlock;+}++if(read_seqcount_retry(&vma->vm_sequence,seq))+gotounlock;++/*+*DoaspeculativelookupofthePTEentry.+*/+local_irq_disable();+pgd=pgd_offset(mm,address);+if(pgd_none(*pgd)||unlikely(pgd_bad(*pgd)))+gotoout_walk;++p4d=p4d_alloc(mm,pgd,address);+if(p4d_none(*p4d)||unlikely(p4d_bad(*p4d)))+gotoout_walk;++pud=pud_alloc(mm,p4d,address);+if(pud_none(*pud)||unlikely(pud_bad(*pud)))+gotoout_walk;++pmd=pmd_offset(pud,address);+if(pmd_none(*pmd)||unlikely(pmd_bad(*pmd)))+gotoout_walk;++/*+*Theabovedoesnotallocate/instantiatepage-tablesbecausedoingso+*wouldleadtothepossibilityofinstantiatingpage-tablesafter+*free_pgtables()--andconsequentlyleakingthem.+*+*Theresultisthatwetakeatleastone!speculativefaultperPMD+*inordertoinstantiateit.+*/++if(unlikely(pmd_huge(*pmd)))+gotoout_walk;++vmf.vma=vma;+vmf.pmd=pmd;+vmf.pgoff=linear_page_index(vma,address);+vmf.gfp_mask=__get_fault_gfp_mask(vma);+vmf.sequence=seq;+vmf.flags=flags;++local_irq_enable();++ret=handle_pte_fault(&vmf);++unlock:+srcu_read_unlock(&vma_srcu,idx);+returnret;++out_walk:+local_irq_enable();+gotounlock;+}+/**Bythetimewegethere,wealreadyholdthemmsemaphore*
From: Peter Zijlstra <peterz@infradead.org>
Try a speculative fault before acquiring mmap_sem, if it returns with
VM_FAULT_RETRY continue with the mmap_sem acquisition and do the
traditional fault.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
[Clearing of FAULT_FLAG_ALLOW_RETRY is now done in
handle_speculative_fault()]
[Retry with usual fault path in the case VM_ERROR is returned by
handle_speculative_fault(). This allows signal to be delivered]
Signed-off-by: Laurent Dufour <redacted>
---
arch/x86/mm/fault.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
This patch enable the speculative page fault on the PowerPC
architecture.
This will try a speculative page fault without holding the mmap_sem,
if it returns with WM_FAULT_RETRY, the mmap_sem is acquired and the
traditional page fault processing is done.
Signed-off-by: Laurent Dufour <redacted>
---
arch/powerpc/mm/fault.c | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
@@ -291,9 +291,31 @@ int do_page_fault(struct pt_regs *regs, unsigned long address,if(is_write&&is_user)store_update_sp=store_updates_sp(regs);-if(is_user)+if(is_user){flags|=FAULT_FLAG_USER;+/* let's try a speculative page fault without grabbing the+*mmap_sem.+*/++/*+*flagsissetlaterbasedontheVMA'sflags,forthecommon+*speculativeservice,weneedsomeflagstobeset.+*/+if(is_write)+flags|=FAULT_FLAG_WRITE;++fault=handle_speculative_fault(mm,address,flags);+if(!(fault&VM_FAULT_RETRY||fault&VM_FAULT_ERROR))+gotodone;++/*+*Resettingflagssincethefollowingcodeassumes+*FAULT_FLAG_WRITEisnotset.+*/+flags&=~FAULT_FLAG_WRITE;+}+/* When running in the kernel we expect faults to occur only to*addressesinuserspace.Allotherfaultsrepresenterrorsinthe*kernelandshouldgenerateanOOPS.Unfortunately,inthecaseofan
@@ -479,6 +501,7 @@ int do_page_fault(struct pt_regs *regs, unsigned long address,rc=0;}+done:/**Major/minorpagefaultaccounting.*/
The speculative page fault handler must be protected against anon_vma
changes. This is because page_add_new_anon_rmap() is called during the
speculative path.
In addition, don't try speculative page fault if the VMA don't have an
anon_vma structure allocated because its allocation should be
protected by the mmap_sem.
In __vma_adjust() when importer->anon_vma is set, there is no need to
protect against speculative page faults since speculative page fault
is aborted if the vma->anon_vma is not set.
When calling page_add_new_anon_rmap() vma->anon_vma is necessarily
valid since we checked for it when locking the pte and the anon_vma is
removed once the pte is unlocked. So even if the speculative page
fault handler is running concurrently with do_unmap(), as the pte is
locked in unmap_region() - through unmap_vmas() - and the anon_vma
unlinked later, because we check for the vma sequence counter which is
updated in unmap_page_range() before locking the pte, and then in
free_pgtables() so when locking the pte the change will be detected.
Signed-off-by: Laurent Dufour <redacted>
---
mm/memory.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
@@ -2403,7 +2407,7 @@ static int wp_page_copy(struct vm_fault *vmf)*threaddoingCOW.*/ptep_clear_flush_notify(vma,vmf->address,vmf->pte);-page_add_new_anon_rmap(new_page,vma,vmf->address,false);+__page_add_new_anon_rmap(new_page,vma,vmf->address,false);mem_cgroup_commit_charge(new_page,memcg,false,false);lru_cache_add_active_or_unevictable(new_page,vma);/*
@@ -2873,7 +2877,7 @@ int do_swap_page(struct vm_fault *vmf)mem_cgroup_commit_charge(page,memcg,true,false);activate_page(page);}else{/* ksm created a completely new copy */-page_add_new_anon_rmap(page,vma,vmf->address,false);+__page_add_new_anon_rmap(page,vma,vmf->address,false);mem_cgroup_commit_charge(page,memcg,false,false);lru_cache_add_active_or_unevictable(page,vma);}
@@ -3015,7 +3019,7 @@ static int do_anonymous_page(struct vm_fault *vmf)}inc_mm_counter_fast(vma->vm_mm,MM_ANONPAGES);-page_add_new_anon_rmap(page,vma,vmf->address,false);+__page_add_new_anon_rmap(page,vma,vmf->address,false);mem_cgroup_commit_charge(page,memcg,false,false);lru_cache_add_active_or_unevictable(page,vma);setpte:
@@ -3940,6 +3944,9 @@ int handle_speculative_fault(struct mm_struct *mm, unsigned long address,if(address<vma->vm_start||vma->vm_end<=address)gotounlock;+if(unlikely(!vma->anon_vma))+gotounlock;+/**Hugepagesarenotyetsupported.*/
When dealing with speculative page fault handler, we may race with VMA
being split or merged. In this case the vma->vm_start and vm->vm_end
fields may not match the address the page fault is occurring.
This can only happens when the VMA is split but in that case, the
anon_vma pointer of the new VMA will be the same as the original one,
because in __split_vma the new->anon_vma is set to src->anon_vma when
*new = *vma.
So even if the VMA boundaries are not correct, the anon_vma pointer is
still valid.
If the VMA has been merged, then the VMA in which it has been merged
must have the same anon_vma pointer otherwise the merge can't be done.
So in all the case we know that the anon_vma is valid, since we have
checked before starting the speculative page fault that the anon_vma
pointer is valid for this VMA and since there is an anon_vma this
means that at one time a page has been backed and that before the VMA
is cleaned, the page table lock would have to be grab to clean the
PTE, and the anon_vma field is checked once the PTE is locked.
This patch introduce a new __page_add_new_anon_rmap() service which
doesn't check for the VMA boundaries, and create a new inline one
which do the check. Currently __page_add_new_anon_rmap() is only
called during the speculative page fault path.
Signed-off-by: Laurent Dufour <redacted>
---
include/linux/rmap.h | 12 ++++++++++--
mm/rmap.c | 5 ++---
2 files changed, 12 insertions(+), 5 deletions(-)
There is a deadlock when a CPU is doing a speculative page fault and
another one is calling do_unmap().
The deadlock occurred because the speculative path try to spinlock the
pte while the interrupt are disabled. When the other CPU in the
unmap's path has locked the pte then is waiting for all the CPU to
invalidate the TLB. As the CPU doing the speculative fault have the
interrupt disable it can't invalidate the TLB, and can't get the lock.
Since we are in a speculative path, we can race with other mm action.
So let assume that the lock may not get acquired and fail the
speculative page fault.
Here are the stacks captured during the deadlock:
CPU 0
native_flush_tlb_others+0x7c/0x260
flush_tlb_mm_range+0x6a/0x220
tlb_flush_mmu_tlbonly+0x63/0xc0
unmap_page_range+0x897/0x9d0
? unmap_single_vma+0x7d/0xe0
? release_pages+0x2b3/0x360
unmap_single_vma+0x7d/0xe0
unmap_vmas+0x51/0xa0
unmap_region+0xbd/0x130
do_munmap+0x279/0x460
SyS_munmap+0x53/0x70
CPU 1
do_raw_spin_lock+0x14e/0x160
_raw_spin_lock+0x5d/0x80
? pte_map_lock+0x169/0x1b0
pte_map_lock+0x169/0x1b0
handle_pte_fault+0xbf2/0xd80
? trace_hardirqs_on+0xd/0x10
handle_speculative_fault+0x272/0x280
handle_speculative_fault+0x5/0x280
__do_page_fault+0x187/0x580
trace_do_page_fault+0x52/0x260
do_async_page_fault+0x19/0x70
async_page_fault+0x28/0x30
Signed-off-by: Laurent Dufour <redacted>
---
mm/memory.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
@@ -301,6 +301,10 @@ static unsigned long move_vma(struct vm_area_struct *vma,if(!new_vma)return-ENOMEM;+write_seqcount_begin(&vma->vm_sequence);+write_seqcount_begin_nested(&new_vma->vm_sequence,+SINGLE_DEPTH_NESTING);+moved_len=move_page_tables(vma,old_addr,new_vma,new_addr,old_len,need_rmap_locks);if(moved_len<old_len){
@@ -317,6 +321,7 @@ static unsigned long move_vma(struct vm_area_struct *vma,*/move_page_tables(new_vma,new_addr,vma,old_addr,moved_len,true);+write_seqcount_end(&vma->vm_sequence);vma=new_vma;old_len=new_len;old_addr=new_addr;
@@ -325,7 +330,9 @@ static unsigned long move_vma(struct vm_area_struct *vma,mremap_userfaultfd_prep(new_vma,uf);arch_remap(mm,old_addr,old_addr+old_len,new_addr,new_addr+new_len);+write_seqcount_end(&vma->vm_sequence);}+write_seqcount_end(&new_vma->vm_sequence);/* Conceal VM_ACCOUNT so old reservation is not undone */if(vm_flags&VM_ACCOUNT){
From: Peter Zijlstra <peterz@infradead.org>
Wrap the VMA modifications (vma_adjust/unmap_page_range) with sequence
counts such that we can easily test if a VMA is changed.
The unmap_page_range() one allows us to make assumptions about
page-tables; when we find the seqcount hasn't changed we can assume
page-tables are still valid.
The flip side is that we cannot distinguish between a vma_adjust() and
the unmap_page_range() -- where with the former we could have
re-checked the vma bounds against the address.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
[Port to 4.12 kernel]
[Fix lock dependency between mapping->i_mmap_rwsem and vma->vm_sequence]
Signed-off-by: Laurent Dufour <redacted>
---
include/linux/mm_types.h | 1 +
mm/memory.c | 2 ++
mm/mmap.c | 21 ++++++++++++++++++---
3 files changed, 21 insertions(+), 3 deletions(-)
@@ -342,6 +342,7 @@ struct vm_area_struct {structmempolicy*vm_policy;/* NUMA policy for the VMA */#endifstructvm_userfaultfd_ctxvm_userfaultfd_ctx;+seqcount_tvm_sequence;}__randomize_layout;structcore_thread{
PERF_COUNT_SW_SPF_FAULTS makes sense but not the FAILED one. IIRC,
there are no error path counting in perf SW events at the moment.
SPF_FAULTS and SPF_FAILS are VM internal events like THP collapse
etc. IMHO it should be added as a VM statistics counter or as a
trace point event instead.
From: Kirill A. Shutemov <hidden> Date: 2017-08-09 10:12:45
On Tue, Aug 08, 2017 at 04:35:38PM +0200, Laurent Dufour wrote:
The VMA sequence count has been introduced to allow fast detection of
VMA modification when running a page fault handler without holding
the mmap_sem.
This patch provides protection agains the VMA modification done in :
- madvise()
- mremap()
- mpol_rebind_policy()
- vma_replace_policy()
- change_prot_numa()
- mlock(), munlock()
- mprotect()
- mmap_region()
- collapse_huge_page()
I don't thinks it's anywhere near complete list of places where we touch
vm_flags. What is your plan for the rest?
--
Kirill A. Shutemov
On Tue, Aug 08, 2017 at 04:35:38PM +0200, Laurent Dufour wrote:
quoted
The VMA sequence count has been introduced to allow fast detection of
VMA modification when running a page fault handler without holding
the mmap_sem.
This patch provides protection agains the VMA modification done in :
- madvise()
- mremap()
- mpol_rebind_policy()
- vma_replace_policy()
- change_prot_numa()
- mlock(), munlock()
- mprotect()
- mmap_region()
- collapse_huge_page()
I don't thinks it's anywhere near complete list of places where we touch
vm_flags. What is your plan for the rest?
The goal is only to protect places where change to the VMA is impacting the
page fault handling. If you think I missed one, please advise.
Thanks,
Laurent.
On Tue, Aug 08, 2017 at 04:35:35PM +0200, Laurent Dufour wrote:
quoted
@@ -2295,7 +2302,11 @@ static int wp_page_copy(struct vm_fault *vmf) /* * Re-check the pte - we dropped the lock */- vmf->pte = pte_offset_map_lock(mm, vmf->pmd, vmf->address, &vmf->ptl);+ if (!pte_map_lock(vmf)) {+ mem_cgroup_cancel_charge(new_page, memcg, false);+ ret = VM_FAULT_RETRY;+ goto oom_free_new;
With the change, label is misleading.
That's right.
But I'm wondering renaming it out to 'out_free_new' and replacing all the
matching 'goto' where the label was making sense will help readability ?
Have you better idea ?
Can't you calculate:
PERF_COUNT_SW_SPF_FAILED = PERF_COUNT_SW_PAGE_FAULTS - PERF_COUNT_SW_SPF_DONE
ie. do you need a separate event for it?
Unfortunately not, because PERF_COUNT_SW_PAGE_FAULTS counts also page
faults from the kernel space, while SPF is only concerning user space page
faults.
Cheers,
Laurent.
From: Kirill A. Shutemov <hidden> Date: 2017-08-10 00:58:33
On Wed, Aug 09, 2017 at 12:43:33PM +0200, Laurent Dufour wrote:
On 09/08/2017 12:12, Kirill A. Shutemov wrote:
quoted
On Tue, Aug 08, 2017 at 04:35:38PM +0200, Laurent Dufour wrote:
quoted
The VMA sequence count has been introduced to allow fast detection of
VMA modification when running a page fault handler without holding
the mmap_sem.
This patch provides protection agains the VMA modification done in :
- madvise()
- mremap()
- mpol_rebind_policy()
- vma_replace_policy()
- change_prot_numa()
- mlock(), munlock()
- mprotect()
- mmap_region()
- collapse_huge_page()
I don't thinks it's anywhere near complete list of places where we touch
vm_flags. What is your plan for the rest?
The goal is only to protect places where change to the VMA is impacting the
page fault handling. If you think I missed one, please advise.
That's very fragile approach. We rely here too much on specific compiler behaviour.
Any write access to vm_flags can, in theory, be translated to several
write accesses. For instance with setting vm_flags to 0 in the middle,
which would result in sigfault on page fault to the vma.
Nothing (apart from common sense) prevents compiler from generating this
kind of pattern.
--
Kirill A. Shutemov
On Wed, Aug 09, 2017 at 12:43:33PM +0200, Laurent Dufour wrote:
quoted
On 09/08/2017 12:12, Kirill A. Shutemov wrote:
quoted
On Tue, Aug 08, 2017 at 04:35:38PM +0200, Laurent Dufour wrote:
quoted
The VMA sequence count has been introduced to allow fast detection of
VMA modification when running a page fault handler without holding
the mmap_sem.
This patch provides protection agains the VMA modification done in :
- madvise()
- mremap()
- mpol_rebind_policy()
- vma_replace_policy()
- change_prot_numa()
- mlock(), munlock()
- mprotect()
- mmap_region()
- collapse_huge_page()
I don't thinks it's anywhere near complete list of places where we touch
vm_flags. What is your plan for the rest?
The goal is only to protect places where change to the VMA is impacting the
page fault handling. If you think I missed one, please advise.
That's very fragile approach. We rely here too much on specific compiler behaviour.
Any write access to vm_flags can, in theory, be translated to several
write accesses. For instance with setting vm_flags to 0 in the middle,
which would result in sigfault on page fault to the vma.
Indeed, just setting vm_flags to 0 will not result in sigfault, the real
job is done when the pte are updated and the bits allowing access are
cleared. Access to the pte is controlled by the pte lock.
Page fault handler is triggered based on the pte bits, not the content of
vm_flags and the speculative page fault is checking for the vma again once
the pte lock is held. So there is no concurrency when dealing with the pte
bits.
Regarding the compiler behaviour, there are memory barriers and locking
which should prevent that.
Thanks,
Laurent.
From: Kirill A. Shutemov <hidden> Date: 2017-08-10 13:43:30
On Thu, Aug 10, 2017 at 10:27:50AM +0200, Laurent Dufour wrote:
On 10/08/2017 02:58, Kirill A. Shutemov wrote:
quoted
On Wed, Aug 09, 2017 at 12:43:33PM +0200, Laurent Dufour wrote:
quoted
On 09/08/2017 12:12, Kirill A. Shutemov wrote:
quoted
On Tue, Aug 08, 2017 at 04:35:38PM +0200, Laurent Dufour wrote:
quoted
The VMA sequence count has been introduced to allow fast detection of
VMA modification when running a page fault handler without holding
the mmap_sem.
This patch provides protection agains the VMA modification done in :
- madvise()
- mremap()
- mpol_rebind_policy()
- vma_replace_policy()
- change_prot_numa()
- mlock(), munlock()
- mprotect()
- mmap_region()
- collapse_huge_page()
I don't thinks it's anywhere near complete list of places where we touch
vm_flags. What is your plan for the rest?
The goal is only to protect places where change to the VMA is impacting the
page fault handling. If you think I missed one, please advise.
That's very fragile approach. We rely here too much on specific compiler behaviour.
Any write access to vm_flags can, in theory, be translated to several
write accesses. For instance with setting vm_flags to 0 in the middle,
which would result in sigfault on page fault to the vma.
Indeed, just setting vm_flags to 0 will not result in sigfault, the real
job is done when the pte are updated and the bits allowing access are
cleared. Access to the pte is controlled by the pte lock.
Page fault handler is triggered based on the pte bits, not the content of
vm_flags and the speculative page fault is checking for the vma again once
the pte lock is held. So there is no concurrency when dealing with the pte
bits.
Suppose we are getting page fault to readable VMA, pte is clear at the
time of page fault. In this case we need to consult vm_flags to check if
the vma is read-accessible.
If by the time of check vm_flags happend to be '0' we would get SIGSEGV as
the vma appears to be non-readable.
Where is my logic faulty?
Regarding the compiler behaviour, there are memory barriers and locking
which should prevent that.
Which locks barriers are you talking about?
We need at least READ_ONCE/WRITE_ONCE to access vm_flags everywhere.
--
Kirill A. Shutemov
On Thu, Aug 10, 2017 at 10:27:50AM +0200, Laurent Dufour wrote:
quoted
On 10/08/2017 02:58, Kirill A. Shutemov wrote:
quoted
On Wed, Aug 09, 2017 at 12:43:33PM +0200, Laurent Dufour wrote:
quoted
On 09/08/2017 12:12, Kirill A. Shutemov wrote:
quoted
On Tue, Aug 08, 2017 at 04:35:38PM +0200, Laurent Dufour wrote:
quoted
The VMA sequence count has been introduced to allow fast detection of
VMA modification when running a page fault handler without holding
the mmap_sem.
This patch provides protection agains the VMA modification done in :
- madvise()
- mremap()
- mpol_rebind_policy()
- vma_replace_policy()
- change_prot_numa()
- mlock(), munlock()
- mprotect()
- mmap_region()
- collapse_huge_page()
I don't thinks it's anywhere near complete list of places where we touch
vm_flags. What is your plan for the rest?
The goal is only to protect places where change to the VMA is impacting the
page fault handling. If you think I missed one, please advise.
That's very fragile approach. We rely here too much on specific compiler behaviour.
Any write access to vm_flags can, in theory, be translated to several
write accesses. For instance with setting vm_flags to 0 in the middle,
which would result in sigfault on page fault to the vma.
Indeed, just setting vm_flags to 0 will not result in sigfault, the real
job is done when the pte are updated and the bits allowing access are
cleared. Access to the pte is controlled by the pte lock.
Page fault handler is triggered based on the pte bits, not the content of
vm_flags and the speculative page fault is checking for the vma again once
the pte lock is held. So there is no concurrency when dealing with the pte
bits.
Suppose we are getting page fault to readable VMA, pte is clear at the
time of page fault. In this case we need to consult vm_flags to check if
the vma is read-accessible.
If by the time of check vm_flags happend to be '0' we would get SIGSEGV as
the vma appears to be non-readable.
Where is my logic faulty?
The speculative page fault handler will not deliver the signal, if the page
fault can't be done in the speculative path for instance because the
vm_flags are not matching the required one, the speculative page fault is
aborted and the *classic* page fault handler is run which will do the job
again grabbing the mmap_sem.
quoted
Regarding the compiler behaviour, there are memory barriers and locking
which should prevent that.
Which locks barriers are you talking about?
When the VMA is modified and that the changes will impact the speculative
page fault handler the sequence count is touch using write_seqcount_begin()
and write_seqcount_end(). These 2 services contains calls to smp_wmb().
On the speculative path side, the calls to *_read_seqcount() contains also
memory barriers calls.
We need at least READ_ONCE/WRITE_ONCE to access vm_flags everywhere.
I don't think READ_ONCE/WRITE_ONCE would help here, as they would not
prevent reading transcient state as the vm_flags example you mentioned.
That said, there are not so much VMA's fields used in the SPF's path and
caching them into the vmf structure under the control of the VMA's sequence
count would solve this.
I'll try to move in that direction unless anyone has a better idea.
Cheers,
Laurent.