[PATCH] powerpc/smp: Get cpu only after validity check

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3295d

2 messages, 2 authors, 2017-07-27 · open the first message on its own page

[PATCH] powerpc/smp: Get cpu only after validity check

From: Santosh Sivaraj <hidden>
Date: 2017-07-04 04:22:57 

Check for validity of cpu before calling get_hard_smp_processor_id.

Found with coverity.

Signed-off-by: Santosh Sivaraj <redacted>
---
 arch/powerpc/platforms/powernv/smp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/smp.c b/arch/powerpc/platforms/powernv/smp.c
index 40dae96..c6448c7 100644
--- a/arch/powerpc/platforms/powernv/smp.c
+++ b/arch/powerpc/platforms/powernv/smp.c
@@ -57,7 +57,7 @@ static void pnv_smp_setup_cpu(int cpu)
 
 static int pnv_smp_kick_cpu(int nr)
 {
-	unsigned int pcpu = get_hard_smp_processor_id(nr);
+	unsigned int pcpu;
 	unsigned long start_here =
 			__pa(ppc_function_entry(generic_secondary_smp_init));
 	long rc;
@@ -66,6 +66,7 @@ static int pnv_smp_kick_cpu(int nr)
 	if (nr < 0 || nr >= nr_cpu_ids)
 		return -EINVAL;
 
+	pcpu = get_hard_smp_processor_id(nr);
 	/*
 	 * If we already started or OPAL is not supported, we just
 	 * kick the CPU via the PACA
-- 
2.9.4

Re: powerpc/smp: Get cpu only after validity check

From: Michael Ellerman <hidden>
Date: 2017-07-27 12:37:18 

On Tue, 2017-07-04 at 04:22:46 UTC, Santosh Sivaraj wrote:
Check for validity of cpu before calling get_hard_smp_processor_id.

Found with coverity.

Signed-off-by: Santosh Sivaraj <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/76d98ab4628bf8d36498e8228a5b92

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help