Re: [v3, 1/8] powerpc/perf/hv-24x7: Fix passing of catalog version number
From: Thiago Jung Bauermann <hidden>
Date: 2017-07-03 13:23:30
From: Thiago Jung Bauermann <hidden>
Date: 2017-07-03 13:23:30
Michael Ellerman [off-list ref] writes:
On Thu, 2017-06-29 at 21:55:31 UTC, Thiago Jung Bauermann wrote:quoted
H_GET_24X7_CATALOG_PAGE needs to be passed the version number obtained from the first catalog page obtained previously. This is a 64 bit number, but create_events_from_catalog truncates it to 32-bit. This worked on POWER8, but POWER9 actually uses the upper bits so the call fails with H_P3 because the hypervisor doesn't recognize the version. This patch also adds the hcall return code to the error message, which is helpful when debugging the problem. Fixes: 5c5cd7b50259 ("powerpc/perf/hv-24x7: parse catalog and populate sysfs with events") Reviewed-by: Sukadev Bhattiprolu <redacted> Signed-off-by: Thiago Jung Bauermann <redacted>Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/12bf85a71000af7419b19b5e909109
Thanks! -- Thiago Jung Bauermann IBM Linux Technology Center