[linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal

Hi 

Today's linux-next fails to boot on ppc bare-metal

Test: Boot
Machine: Power 8 bare-metal
kernel: 4.12.0-next-20170713
gcc: version 4.8.5
config : Tul-NV-config attached.

boot logs:
----------
OPAL nvram setup, 1048576 bytes
Zone ranges:
  DMA      [mem 0x0000000000000000-0x0000000fffffffff]
  DMA32    empty
  Normal   empty
Movable zone start for each node
Early memory node ranges
  node   0: [mem 0x0000000000000000-0x00000007ffffffff]
  node   1: [mem 0x0000000800000000-0x0000000fffffffff]
Initmem setup node 0 [mem 0x0000000000000000-0x00000007ffffffff]

Machine boot is stuck after this.

Possible first bad commit looks to be :

1c0eaf0f56d6128af7f0f252855173fcee85d202 is the first bad commit
commit 1c0eaf0f56d6128af7f0f252855173fcee85d202
Author: Benjamin Herrenschmidt [off-list ref]
Date:   Fri Jun 30 17:37:32 2017 -0500

    powerpc/powernv: Tell OPAL about our MMU mode on POWER9
    
    That will allow OPAL to configure the CPU in an optimal way.
    
    Signed-off-by: Benjamin Herrenschmidt [off-list ref]
    Signed-off-by: Michael Neuling [off-list ref]
    Signed-off-by: Michael Ellerman [off-list ref]

:040000 040000 6605393385631357131c0701795e1d51c8e458c8 

git bisect start
# good: [a2b313034fc5c6870ddf2d116f16d45e38c6a64e] Merge branch 'pci-pm'
into linux-next
git bisect good a2b313034fc5c6870ddf2d116f16d45e38c6a64e
# bad: [4f318fb1406897652aedea36d062b89b33adcab3] Merge branch
'akpm-current/current'
git bisect bad 4f318fb1406897652aedea36d062b89b33adcab3
# bad: [8f3788ee212bb8089f3c8c69577f53790a17cc4e] Merge remote-tracking
branch 'vfs/for-next'
git bisect bad 8f3788ee212bb8089f3c8c69577f53790a17cc4e
# bad: [b7190d530867970e917c76033e4725e57d6d2c08] Merge remote-tracking
branch 'sparc/master'
git bisect bad b7190d530867970e917c76033e4725e57d6d2c08
# good: [3bf7878f0f7d60c394f6d6631bb179e86f09f73c] Merge tag
'ceph-for-4.13-rc1' of git://github.com/ceph/ceph-client
git bisect good 3bf7878f0f7d60c394f6d6631bb179e86f09f73c
# good: [6b1c776d3efbda31085b6a9f3bc7f774511fafd9] Merge branch
'overlayfs-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
git bisect good 6b1c776d3efbda31085b6a9f3bc7f774511fafd9
# good: [fb4e3beeffa47619985f190663c6ef424f063a22] Merge tag
'iommu-updates-v4.13' of
git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu
git bisect good fb4e3beeffa47619985f190663c6ef424f063a22
# good: [606fd2788b0fce6f5138078a4fbe8979ecba5697] i2c: algo-bit: add
support for I2C_M_STOP
git bisect good 606fd2788b0fce6f5138078a4fbe8979ecba5697
# good: [9809cb831c9645d61ee9501c308045bb3d8afd31] i2c: designware: fix
spelling mistakes
git bisect good 9809cb831c9645d61ee9501c308045bb3d8afd31
# good: [6be1d03c529d922c7d65608638f4431a85272aa9] Merge remote-tracking
branch 'arc-current/for-curr'
git bisect good 6be1d03c529d922c7d65608638f4431a85272aa9
# bad: [3a6a04706fd08eb5677fdfc086e26fcd5eb154f4] powerpc/mm/radix:
Synchronize updates to the process table
git bisect bad 3a6a04706fd08eb5677fdfc086e26fcd5eb154f4
# bad: [1c0eaf0f56d6128af7f0f252855173fcee85d202] powerpc/powernv: Tell
OPAL about our MMU mode on POWER9
git bisect bad 1c0eaf0f56d6128af7f0f252855173fcee85d202
# good: [1e2a516e89fc412a754327522ab271b42f99c6b4] powerpc/kexec: Fix
radix to hash kexec due to IAMR/AMOR
git bisect good 1e2a516e89fc412a754327522ab271b42f99c6b4
# first bad commit: [1c0eaf0f56d6128af7f0f252855173fcee85d202]
powerpc/powernv: Tell OPAL about our MMU mode on POWER9

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre

Hi Abdul,

Thanks for the bug report.

Abdul Haleem [off-list ref] writes:

Hi 

Today's linux-next fails to boot on ppc bare-metal

Test: Boot
Machine: Power 8 bare-metal
kernel: 4.12.0-next-20170713
gcc: version 4.8.5
config : Tul-NV-config attached.

[swearing redacted]

Does this help?

cheers

diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 9b87abb178f0..cad6b57ce494 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c

@@ -78,7 +78,7 @@ void opal_configure_cores(void)
 	 *  ie. Host hash  supports  hash guests
 	 *      Host radix supports  hash/radix guests
 	 */
-	if (cpu_has_feature(CPU_FTR_ARCH_300)) {
+	if (early_cpu_has_feature(CPU_FTR_ARCH_300)) {
 		reinit_flags |= OPAL_REINIT_CPUS_MMU_HASH;
 		if (early_radix_enabled())
 			reinit_flags |= OPAL_REINIT_CPUS_MMU_RADIX;

On Mon, 2017-07-17 at 12:10 +1000, Michael Ellerman wrote:

Hi Abdul,

Thanks for the bug report.

Abdul Haleem [off-list ref] writes:

quoted

Hi 

Today's linux-next fails to boot on ppc bare-metal

Test: Boot
Machine: Power 8 bare-metal
kernel: 4.12.0-next-20170713
gcc: version 4.8.5
config : Tul-NV-config attached.

[swearing redacted]

Does this help?

Yes, it fixes the boot issue. Thanks for the fix.

With below patch, I was able to successfully boot
4.13.0-rc1-next-20170717 kernel on ppc bare-metal

Reported-and-tested-by: Abdul Haleem <redacted>

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre