[PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3324d

4 messages, 3 authors, 2017-07-03 · open the first message on its own page

[PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT

From: Oliver O'Halloran <oohall@gmail.com>
Date: 2017-06-30 06:52:57

Export it so it can be referenced inside a module.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
 arch/powerpc/mm/hugetlbpage.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index ceeab69cf7fc..96293560f294 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -34,6 +34,7 @@
 #define PAGE_SHIFT_16G	34
 
 unsigned int HPAGE_SHIFT;
+EXPORT_SYMBOL(HPAGE_SHIFT);
 
 /*
  * Tracks gpages after the device tree is scanned and before the
-- 
2.9.4

Re: [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT

From: Anshuman Khandual <hidden>
Date: 2017-06-30 09:29:10

On 06/30/2017 12:22 PM, Oliver O'Halloran wrote:
quoted hunk
Export it so it can be referenced inside a module.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
 arch/powerpc/mm/hugetlbpage.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index ceeab69cf7fc..96293560f294 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -34,6 +34,7 @@
 #define PAGE_SHIFT_16G	34

 unsigned int HPAGE_SHIFT;
+EXPORT_SYMBOL(HPAGE_SHIFT);
Why would you need this in a driver ? This represents the
default HugeTLB page size.

Re: powerpc/hugetlbfs: Export HPAGE_SHIFT

From: Michael Ellerman <hidden>
Date: 2017-07-02 11:01:44

On Fri, 2017-06-30 at 06:52:35 UTC, Oliver O'Halloran wrote:
Export it so it can be referenced inside a module.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/7a849a6cf3ff676d1726259c18fa41

cheers

Re: [PATCH] powerpc/hugetlbfs: Export HPAGE_SHIFT

From: Oliver <oohall@gmail.com>
Date: 2017-07-03 03:36:49

On Fri, Jun 30, 2017 at 7:28 PM, Anshuman Khandual
[off-list ref] wrote:
On 06/30/2017 12:22 PM, Oliver O'Halloran wrote:
quoted
Export it so it can be referenced inside a module.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
 arch/powerpc/mm/hugetlbpage.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index ceeab69cf7fc..96293560f294 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -34,6 +34,7 @@
 #define PAGE_SHIFT_16G       34

 unsigned int HPAGE_SHIFT;
+EXPORT_SYMBOL(HPAGE_SHIFT);
Why would you need this in a driver ? This represents the
default HugeTLB page size.
Libnvdimm uses HPAGE_SIZE for a few things that it probably shouldn't.
I have sent a fix for libnvdimm, but that hasn't been merged yet and
this was breaking mpe's -next builds in the mean time. I agree it's
kind of bad, but we needed ZONE_DEVICE support to be in 4.13.

Oliver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help