[PATCH] powerpc/kprobes: Don't save/restore DAR/DSISR to/from pt_regs for optprobes

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3263d

2 messages, 2 authors, 2017-08-31 · open the first message on its own page

[PATCH] powerpc/kprobes: Don't save/restore DAR/DSISR to/from pt_regs for optprobes

From: Naveen N. Rao <hidden>
Date: 2017-06-08 19:17:19 

We don't save/restore these across a trap, or with KPROBES_ON_FTRACE.

Signed-off-by: Naveen N. Rao <redacted>
---
 arch/powerpc/kernel/optprobes_head.S | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/powerpc/kernel/optprobes_head.S b/arch/powerpc/kernel/optprobes_head.S
index 4937bef7652f..52fc864cdec4 100644
--- a/arch/powerpc/kernel/optprobes_head.S
+++ b/arch/powerpc/kernel/optprobes_head.S
@@ -60,10 +60,6 @@ optprobe_template_entry:
 	std	r5,_CCR(r1)
 	lbz     r5,PACASOFTIRQEN(r13)
 	std     r5,SOFTE(r1)
-	mfdar	r5
-	std	r5,_DAR(r1)
-	mfdsisr	r5
-	std	r5,_DSISR(r1)
 
 	/*
 	 * We may get here from a module, so load the kernel TOC in r2.
@@ -122,10 +118,6 @@ optprobe_template_call_emulate:
 	mtxer	r5
 	ld	r5,_CCR(r1)
 	mtcr	r5
-	ld	r5,_DAR(r1)
-	mtdar	r5
-	ld	r5,_DSISR(r1)
-	mtdsisr	r5
 	REST_GPR(0,r1)
 	REST_10GPRS(2,r1)
 	REST_10GPRS(12,r1)
-- 
2.12.2

Re: powerpc/kprobes: Don't save/restore DAR/DSISR to/from pt_regs for optprobes

From: Michael Ellerman <hidden>
Date: 2017-08-31 11:36:01 

On Thu, 2017-06-08 at 19:16:55 UTC, "Naveen N. Rao" wrote:
We don't save/restore these across a trap, or with KPROBES_ON_FTRACE.

Signed-off-by: Naveen N. Rao <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ec4189c4e8eea0c5e7c9b71cb1502c

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help