# Re: \[PATCH 06/44\] iommu/dma: don't rely on DMA\_ERROR\_CODE

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2017-06-16 08:37:06 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2017/06/5022471
- Thread: https://ratatoskr.run/linux-arm-kernel/2017/06/5016133/t.md

```text
On Thu, Jun 08, 2017 at 02:59:07PM +0100, Robin Murphy wrote:
> Hi Christoph,
> 
> On 08/06/17 14:25, Christoph Hellwig wrote:
> > DMA_ERROR_CODE is not a public API and will go away soon.  dma dma-iommu
> > driver already implements a proper ->mapping_error method, so it's only
> > using the value internally.  Add a new local define using the value
> > that arm64 which is the only current user of dma-iommu.
> 
> It would be fine to just use 0, since dma-iommu already makes sure that
> that will never be allocated for a valid DMA address.

I'll change it to 0.

> Otherwise, looks good!

Can you give me a formal ACK or Reviewed-by: ?
```