Re: [PATCH] powerpc: dts: use #include "..." to include local DT

2 messages, 2 authors, 2017-06-13 · open the first message on its own page

Re: [PATCH] powerpc: dts: use #include "..." to include local DT

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-06-13 10:21:49

Masahiro Yamada [off-list ref] writes:
Hi

(+Anatolij Gustschin [off-list ref])


Ping.
I am not 100% sure who is responsible for this,
but somebody, could take a look at this patch, please?
Have you tested it actually works?

It sounds reasonable, and if it behaves as you describe there is no
change in behaviour, right?

cheers
2017-05-24 14:12 GMT+09:00 Masahiro Yamada [off-list ref]:
quoted
Most of DT files in PowerPC use #include "..." to make pre-processor
include DT in the same directory, but we have 3 exceptional files
that use #include <...> for that.

Fix them to remove -I$(srctree)/arch/$(SRCARCH)/boot/dts path from
dtc_cpp_flags.

Signed-off-by: Masahiro Yamada <redacted>
---

 arch/powerpc/boot/dts/ac14xx.dts     | 2 +-
 arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
 arch/powerpc/boot/dts/pdm360ng.dts   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac14xx.dts
index 27fcabc2f857..83bcfd865167 100644
--- a/arch/powerpc/boot/dts/ac14xx.dts
+++ b/arch/powerpc/boot/dts/ac14xx.dts
@@ -10,7 +10,7 @@
  */


-#include <mpc5121.dtsi>
+#include "mpc5121.dtsi"

 / {
        model = "ac14xx";
diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts
index 75888ce2c792..73c30621429b 100644
--- a/arch/powerpc/boot/dts/mpc5121ads.dts
+++ b/arch/powerpc/boot/dts/mpc5121ads.dts
@@ -9,7 +9,7 @@
  * option) any later version.
  */

-#include <mpc5121.dtsi>
+#include "mpc5121.dtsi"

 / {
        model = "mpc5121ads";
diff --git a/arch/powerpc/boot/dts/pdm360ng.dts b/arch/powerpc/boot/dts/pdm360ng.dts
index 0cec7244abe7..445b88114009 100644
--- a/arch/powerpc/boot/dts/pdm360ng.dts
+++ b/arch/powerpc/boot/dts/pdm360ng.dts
@@ -13,7 +13,7 @@
  * option) any later version.
  */

-#include <mpc5121.dtsi>
+#include "mpc5121.dtsi"

 / {
        model = "pdm360ng";
--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Best Regards
Masahiro Yamada

Re: [PATCH] powerpc: dts: use #include "..." to include local DT

From: Anatolij Gustschin <agust@denx.de>
Date: 2017-06-13 13:10:52

On Tue, 13 Jun 2017 20:21:45 +1000
Michael Ellerman mpe@ellerman.id.au wrote:
Masahiro Yamada [off-list ref] writes:
...
quoted
Ping.
I am not 100% sure who is responsible for this,
but somebody, could take a look at this patch, please?  
Have you tested it actually works?

It sounds reasonable, and if it behaves as you describe there is no
change in behaviour, right?
yes, these dtbs build with this patch and I've tested with
mpc5121ads.dtb.

Thanks,
Anatolij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help