# Re: \[PATCH 07/44\] xen-swiotlb: consolidate xen\_swiotlb\_dma\_ops

- From: Konrad Rzeszutek Wilk \<hidden\>
- Date: 2017-06-11 02:38:18 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2017/06/5017949
- Thread: https://ratatoskr.run/linux-arm-kernel/2017/06/5016133/t.md

```text
On Thu, Jun 08, 2017 at 03:25:32PM +0200, Christoph Hellwig wrote:
> ARM and x86 had duplicated versions of the dma_ops structure, the
> only difference is that x86 hasn't wired up the set_dma_mask,
> mmap, and get_sgtable ops yet.  On x86 all of them are identical
> to the generic version, so they aren't needed but harmless.
> 
> All the symbols used only for xen_swiotlb_dma_ops can now be marked
> static as well.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/arm/xen/mm.c              | 17 --------
>  arch/x86/xen/pci-swiotlb-xen.c | 14 -------
>  drivers/xen/swiotlb-xen.c      | 93 ++++++++++++++++++++++--------------------
>  include/xen/swiotlb-xen.h      | 62 +---------------------------
>  4 files changed, 49 insertions(+), 137 deletions(-)

Yeeey!

Reviewed-by: Konrad Rzeszutek Wilk <redacted>
```