[PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

Subsystems: ibm power sriov virtual nic device driver, linux for powerpc (32-bit and 64-bit), networking drivers, the rest

STALE3363d

3 messages, 3 authors, 2017-05-18 · open the first message on its own page

[PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

From: Wei Yongjun <hidden>
Date: 2017-05-18 15:25:04

From: Wei Yongjun <redacted>

Add the missing unlock before return from function __ibmvnic_reset()
in the error handling case.

Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 4f2d329..27f7933 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1313,6 +1313,7 @@ static void __ibmvnic_reset(struct work_struct *work)
 
 	if (rc) {
 		free_all_rwi(adapter);
+		mutex_unlock(&adapter->reset_lock);
 		return;
 	}

Re: [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

From: Nathan Fontenot <hidden>
Date: 2017-05-18 17:29:44

On 05/18/2017 10:24 AM, Wei Yongjun wrote:
From: Wei Yongjun <redacted>

Add the missing unlock before return from function __ibmvnic_reset()
in the error handling case.

Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: Wei Yongjun <redacted>
Reviewed-by: Nathan Fontenot <redacted>
quoted hunk
---
 drivers/net/ethernet/ibm/ibmvnic.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 4f2d329..27f7933 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1313,6 +1313,7 @@ static void __ibmvnic_reset(struct work_struct *work)

 	if (rc) {
 		free_all_rwi(adapter);
+		mutex_unlock(&adapter->reset_lock);
 		return;
 	}

Re: [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

From: David Miller <davem@davemloft.net>
Date: 2017-05-18 19:18:57

From: Wei Yongjun <redacted>
Date: Thu, 18 May 2017 15:24:52 +0000
From: Wei Yongjun <redacted>

Add the missing unlock before return from function __ibmvnic_reset()
in the error handling case.

Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help