[PATCH] powerpc: fix distclean with Makefile.postlink

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3378d

5 messages, 4 authors, 2017-05-15 · open the first message on its own page

[PATCH] powerpc: fix distclean with Makefile.postlink

From: Horia Geantă <horia.geanta@nxp.com>
Date: 2017-05-08 08:50:37

Makefile.postlink always includes include/config/auto.conf, however
this file is not present in a clean kernel tree, causing make to fail:

arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
make: *** [vmlinuxclean] Error 2

Change the inclusion such that file not being found does not trigger
an error.

Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
Reported-by: Mircea Pop <redacted>
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
 arch/powerpc/Makefile.postlink | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/Makefile.postlink b/arch/powerpc/Makefile.postlink
index 3c22d64b2de9..eccfcc88afae 100644
--- a/arch/powerpc/Makefile.postlink
+++ b/arch/powerpc/Makefile.postlink
@@ -7,7 +7,7 @@
 PHONY := __archpost
 __archpost:
 
-include include/config/auto.conf
+-include include/config/auto.conf
 include scripts/Kbuild.include
 
 quiet_cmd_relocs_check = CHKREL  $@
-- 
2.12.0.264.gd6db3f216544

Re: [PATCH] powerpc: fix distclean with Makefile.postlink

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-05-08 11:57:55

Horia Geant=C4=83 [off-list ref] writes:
Makefile.postlink always includes include/config/auto.conf, however
this file is not present in a clean kernel tree, causing make to fail:

arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file=
 or directory
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
make: *** [vmlinuxclean] Error 2

Change the inclusion such that file not being found does not trigger
an error.

Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check reloca=
tions")

I can't reproduce this. What exact steps are you doing? And what version
of Make?

cheers

Re: [PATCH] powerpc: fix distclean with Makefile.postlink

From: Horia Geantă <horia.geanta@nxp.com>
Date: 2017-05-08 13:50:48

On 5/8/2017 2:57 PM, Michael Ellerman wrote:=0A=
Horia Geant=E3 [off-list ref] writes:=0A=
=0A=
quoted
Makefile.postlink always includes include/config/auto.conf, however=0A=
this file is not present in a clean kernel tree, causing make to fail:=
=0A=
quoted
=0A=
arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such fil=
e or directory=0A=
quoted
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.=
=0A=
quoted
make: *** [vmlinuxclean] Error 2=0A=
=0A=
Change the inclusion such that file not being found does not trigger=0A=
an error.=0A=
=0A=
Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check reloc=
ations")=0A=
=0A=
I can't reproduce this. What exact steps are you doing? And what version=
=0A=
of Make?=0A=
=0A=
Start with a clean kernel tree and then=0A=
make distclean=0A=
arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such=0A=
file or directory=0A=
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.=0A=
make: *** [vmlinuxclean] Error 2=0A=
=0A=
make --version=0A=
GNU Make 3.82=0A=
Built for x86_64-redhat-linux-gnu=0A=
Copyright (C) 2010  Free Software Foundation, Inc.=0A=
[...]=0A=
=0A=
The fix is basically the same as:=0A=
6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink=0A=
=0A=
Regards,=0A=
Horia=0A=
=0A=

Re: [PATCH] powerpc: fix distclean with Makefile.postlink

From: Justin Forbes <hidden>
Date: 2017-05-08 21:35:47

On Mon, May 8, 2017 at 8:50 AM, Horia Geant=C4=83 [off-list ref] wr=
ote:
On 5/8/2017 2:57 PM, Michael Ellerman wrote:
quoted
Horia Geant=C4=83 [off-list ref] writes:
quoted
Makefile.postlink always includes include/config/auto.conf, however
this file is not present in a clean kernel tree, causing make to fail:

arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such fi=
le or directory
quoted
quoted
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
make: *** [vmlinuxclean] Error 2

Change the inclusion such that file not being found does not trigger
an error.

Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relo=
cations")
quoted
I can't reproduce this. What exact steps are you doing? And what version
of Make?
Start with a clean kernel tree and then
make distclean
arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
file or directory
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
make: *** [vmlinuxclean] Error 2

make --version
GNU Make 3.82
Built for x86_64-redhat-linux-gnu
Copyright (C) 2010  Free Software Foundation, Inc.
[...]

The fix is basically the same as:
6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink
Noticed it on the Fedora builds as well today.  This patch fixes it.

Tested-by: Justin M. Forbes <redacted>

Re: powerpc: fix distclean with Makefile.postlink

From: Michael Ellerman <hidden>
Date: 2017-05-15 05:06:50

On Mon, 2017-05-08 at 08:50:16 UTC, =?utf-8?q?Horia_Geant=C4=83?= wrote:
Makefile.postlink always includes include/config/auto.conf, however
this file is not present in a clean kernel tree, causing make to fail:

arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
make: *** [vmlinuxclean] Error 2

Change the inclusion such that file not being found does not trigger
an error.

Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
Reported-by: Mircea Pop <redacted>
Signed-off-by: Horia Geant�� <horia.geanta@nxp.com>
Tested-by: Justin M. Forbes <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/24e0bfbf63bac18495b0ad76115269

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help