[PATCH kernel] KVM: PPC: Check kzalloc() return

Subsystems: kernel virtual machine for powerpc (kvm/powerpc), linux for powerpc (32-bit and 64-bit), the rest

STALE3430d

2 messages, 2 authors, 2017-03-27 · open the first message on its own page

[PATCH kernel] KVM: PPC: Check kzalloc() return

From: Alexey Kardashevskiy <hidden>
Date: 2017-03-27 03:19:33

This adds missing check for failed kzalloc().

Signed-off-by: Alexey Kardashevskiy <redacted>
---

This is a followup change for:
[PATCH kernel v11 10/10] KVM: PPC: VFIO: Add in-kernel acceleration for VFIO

Please squash it. Thanks!
---
 arch/powerpc/kvm/book3s_64_vio.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
index 22c67a47eaab..c3d8a88f1f4e 100644
--- a/arch/powerpc/kvm/book3s_64_vio.c
+++ b/arch/powerpc/kvm/book3s_64_vio.c
@@ -212,6 +212,11 @@ extern long kvm_spapr_tce_attach_iommu_group(struct kvm *kvm, int tablefd,
 	}
 
 	stit = kzalloc(sizeof(*stit), GFP_KERNEL);
+	if (!stit) {
+		iommu_tce_table_put(tbl);
+		return -ENOMEM;
+	}
+
 	stit->tbl = tbl;
 	kref_init(&stit->kref);
 
-- 
2.11.0

Re: [PATCH kernel] KVM: PPC: Check kzalloc() return

From: David Gibson <hidden>
Date: 2017-03-27 06:31:20

On Mon, Mar 27, 2017 at 02:19:27PM +1100, Alexey Kardashevskiy wrote:
This adds missing check for failed kzalloc().

Signed-off-by: Alexey Kardashevskiy <redacted>
Reviewed-by: David Gibson <redacted>
quoted hunk
---

This is a followup change for:
[PATCH kernel v11 10/10] KVM: PPC: VFIO: Add in-kernel acceleration for VFIO

Please squash it. Thanks!
---
 arch/powerpc/kvm/book3s_64_vio.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
index 22c67a47eaab..c3d8a88f1f4e 100644
--- a/arch/powerpc/kvm/book3s_64_vio.c
+++ b/arch/powerpc/kvm/book3s_64_vio.c
@@ -212,6 +212,11 @@ extern long kvm_spapr_tce_attach_iommu_group(struct kvm *kvm, int tablefd,
 	}
 
 	stit = kzalloc(sizeof(*stit), GFP_KERNEL);
+	if (!stit) {
+		iommu_tce_table_put(tbl);
+		return -ENOMEM;
+	}
+
 	stit->tbl = tbl;
 	kref_init(&stit->kref);
 
-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help