[PATCH] powerpc/mm: Add translation mode information in /proc/cpuinfo

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3448d

6 messages, 4 authors, 2017-02-27 · open the first message on its own page

[PATCH] powerpc/mm: Add translation mode information in /proc/cpuinfo

From: Aneesh Kumar K.V <hidden>
Date: 2017-02-19 10:18:08

With this we have on powernv and pseries /proc/cpuinfo reporting

timebase        : 512000000
platform        : PowerNV
model           : 8247-22L
machine         : PowerNV 8247-22L
firmware        : OPAL
translation     : Hash

Signed-off-by: Aneesh Kumar K.V <redacted>
---
 arch/powerpc/platforms/powernv/setup.c | 4 ++++
 arch/powerpc/platforms/pseries/setup.c | 4 ++++
 2 files changed, 8 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index d50c7d99baaf..d38571e289bb 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m)
 	else
 		seq_printf(m, "firmware\t: BML\n");
 	of_node_put(root);
+	if (radix_enabled())
+		seq_printf(m, "translation\t: Radix\n");
+	else
+		seq_printf(m, "translation\t: Hash\n");
 }
 
 static void pnv_prepare_going_down(void)
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 7736352f7279..6576fe306561 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -86,6 +86,10 @@ static void pSeries_show_cpuinfo(struct seq_file *m)
 		model = of_get_property(root, "model", NULL);
 	seq_printf(m, "machine\t\t: CHRP %s\n", model);
 	of_node_put(root);
+	if (radix_enabled())
+		seq_printf(m, "translation\t: Radix\n");
+	else
+		seq_printf(m, "translation\t: Hash\n");
 }
 
 /* Initialize firmware assisted non-maskable interrupts if
-- 
2.7.4

Re: [PATCH] powerpc/mm: Add translation mode information in /proc/cpuinfo

From: Balbir Singh <bsingharora@gmail.com>
Date: 2017-02-22 00:24:00

On Sun, Feb 19, 2017 at 03:47:49PM +0530, Aneesh Kumar K.V wrote:
With this we have on powernv and pseries /proc/cpuinfo reporting

timebase        : 512000000
platform        : PowerNV
model           : 8247-22L
machine         : PowerNV 8247-22L
firmware        : OPAL
translation     : Hash

Signed-off-by: Aneesh Kumar K.V <redacted>
---
Acked-by: Balbir Singh <bsingharora@gmail.com>

Re: [PATCH] powerpc/mm: Add translation mode information in /proc/cpuinfo

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-02-22 05:45:47

"Aneesh Kumar K.V" [off-list ref] writes:
quoted hunk
With this we have on powernv and pseries /proc/cpuinfo reporting

timebase        : 512000000
platform        : PowerNV
model           : 8247-22L
machine         : PowerNV 8247-22L
firmware        : OPAL
translation     : Hash

Signed-off-by: Aneesh Kumar K.V <redacted>
---
 arch/powerpc/platforms/powernv/setup.c | 4 ++++
 arch/powerpc/platforms/pseries/setup.c | 4 ++++
 2 files changed, 8 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index d50c7d99baaf..d38571e289bb 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m)
 	else
 		seq_printf(m, "firmware\t: BML\n");
 	of_node_put(root);
+	if (radix_enabled())
+		seq_printf(m, "translation\t: Radix\n");
+	else
+		seq_printf(m, "translation\t: Hash\n");
 }
Can we just call it "MMU" ?

I don't think it's entirely clear what "translation" means here if you
don't already know.

cheers

Re: [PATCH] powerpc/mm: Add translation mode information in /proc/cpuinfo

From: Aneesh Kumar K.V <hidden>
Date: 2017-02-22 05:49:22


On Wednesday 22 February 2017 11:15 AM, Michael Ellerman wrote:
"Aneesh Kumar K.V" [off-list ref] writes:
quoted
With this we have on powernv and pseries /proc/cpuinfo reporting

timebase        : 512000000
platform        : PowerNV
model           : 8247-22L
machine         : PowerNV 8247-22L
firmware        : OPAL
translation     : Hash

Signed-off-by: Aneesh Kumar K.V <redacted>
---
  arch/powerpc/platforms/powernv/setup.c | 4 ++++
  arch/powerpc/platforms/pseries/setup.c | 4 ++++
  2 files changed, 8 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index d50c7d99baaf..d38571e289bb 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m)
  	else
  		seq_printf(m, "firmware\t: BML\n");
  	of_node_put(root);
+	if (radix_enabled())
+		seq_printf(m, "translation\t: Radix\n");
+	else
+		seq_printf(m, "translation\t: Hash\n");
  }
Can we just call it "MMU" ?

I don't think it's entirely clear what "translation" means here if you
don't already know.

cheers
I avoided using MMU, because it will confuse hardware guys. Radix is not 
clearly the full definition of
Memory management unit, but rather the translation mode used by memory 
management unit. But
i don't have strong opinion on this.

Do you want me to send an updated patch ? or you can update it when you 
apply it to your tree ?

-aneesh

Re: [PATCH] powerpc/mm: Add translation mode information in /proc/cpuinfo

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2017-02-22 08:03:17

On Wed, 2017-02-22 at 11:19 +0530, Aneesh Kumar K.V wrote:
I avoided using MMU, because it will confuse hardware guys.
Why would it ? I don't see how anybody would be confused. And they
aren't the primary consumers of /proc/cpuinfo anyway. I agree with
Michal here.
 Radix is not 
clearly the full definition of
Memory management unit, but rather the translation mode used by memory 
management unit. But
i don't have strong opinion on this.
Who cares ? People understand :-) If you want call it "MMU Mode: if you
think it's cleared but I don't like too much having a space on the left
in case of stupid parsers...
Do you want me to send an updated patch ? or you can update it when you 
apply it to your tree ?

-aneesh

Re: [PATCH] powerpc/mm: Add translation mode information in /proc/cpuinfo

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-02-27 09:56:32

"Aneesh Kumar K.V" [off-list ref] writes:
On Wednesday 22 February 2017 11:15 AM, Michael Ellerman wrote:
quoted
"Aneesh Kumar K.V" [off-list ref] writes:
quoted
diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index d50c7d99baaf..d38571e289bb 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m)
  	else
  		seq_printf(m, "firmware\t: BML\n");
  	of_node_put(root);
+	if (radix_enabled())
+		seq_printf(m, "translation\t: Radix\n");
+	else
+		seq_printf(m, "translation\t: Hash\n");
  }
Can we just call it "MMU" ?
...
Do you want me to send an updated patch ? or you can update it when you 
apply it to your tree ?
I'll fix it up.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help