Re: [PATCH 05/12] drm/ast: Fix calculation of MCLK
From: Joel Stanley <joel@jms.id.au>
Date: 2017-02-24 03:12:43
Also in:
dri-devel
From: Joel Stanley <joel@jms.id.au>
Date: 2017-02-24 03:12:43
Also in:
dri-devel
On Fri, Feb 24, 2017 at 1:08 PM, Benjamin Herrenschmidt [off-list ref] wrote:
On Fri, 2017-02-24 at 12:54 +1030, Joel Stanley wrote:quoted
On Fri, Feb 24, 2017 at 9:23 AM, Benjamin Herrenschmidt [off-list ref] wrote:quoted
Some braces were missing causing an incorrect calculation. Y.C. Chen from Aspeed provided me with the right formula which I tested on AST2400 and 2500.Y. C. Chen, can you point out this calculation in the programming guide? All of the PLL calculations I can find in the ast2400 documentation are different to this one.Different PLL register, see my other email. I've checked the result of the calculation on our AST2500 and AST2400 machines.
I see now. It woudl be good to see the calculation added to Aspeed's documentation in the future. Acked-by: Joel Stanley <joel@jms.id.au> Cheers, Joel