[PowerPC] 4.10.0 fails to build on BE config

5 messages, 5 authors, 2017-02-21 · open the first message on its own page

[PowerPC] 4.10.0 fails to build on BE config

From: abdul <hidden>
Date: 2017-02-21 07:26:15

Hi,

Today's mainline build, breaks on Power6 and Power7 (all BE config) with 
these build errors

arch/powerpc/kernel/time.c: In function ‘running_clock’:
arch/powerpc/kernel/time.c:712:2: error: implicit declaration of 
function ‘cputime_to_nsecs’ [-Werror=implicit-function-declaration]
return local_clock() - 
cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
^
cc1: some warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/time.o] Error 1


Regard's
Abdul Haleem
IBM Linux Technology Center.

Re: [PowerPC] 4.10.0 fails to build on BE config

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-02-21 10:25:00

abdul [off-list ref] writes:
Hi,

Today's mainline build, breaks on Power6 and Power7 (all BE config) with=
=20
these build errors

arch/powerpc/kernel/time.c: In function =E2=80=98running_clock=E2=80=99:
arch/powerpc/kernel/time.c:712:2: error: implicit declaration of=20
function =E2=80=98cputime_to_nsecs=E2=80=99 [-Werror=3Dimplicit-function-=
declaration]
return local_clock() -=20
cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
^
cc1: some warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/time.o] Error 1
What exact config is that?

And what compiler are you using?

I build ~250 configs with two different compilers multiple times a day,
so I'm curious how we failed to notice this.

cheers

Re: [PowerPC] 4.10.0 fails to build on BE config

From: "Oliver O'Halloran" <oohall@gmail.com>
Date: 2017-02-21 11:09:35

On Tue, Feb 21, 2017 at 6:25 PM, abdul [off-list ref] wrote:
Hi,

Today's mainline build, breaks on Power6 and Power7 (all BE config) with
these build errors

arch/powerpc/kernel/time.c: In function =E2=80=98running_clock=E2=80=99:
arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function
=E2=80=98cputime_to_nsecs=E2=80=99 [-Werror=3Dimplicit-function-declarati=
on]
return local_clock() -
cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
^
cc1: some warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/time.o] Error 1


Regard's
Abdul Haleem
IBM Linux Technology Center.
Hi Abdul,

Are there any extra patches in your tree? I briefly tried to reproduce
this, but in my local tree this line:
return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIM=
E_STEAL]);

Is at time.c:692 rather than time.c:712

Oliver

Re: [PowerPC] 4.10.0 fails to build on BE config

From: Sachin Sant <hidden>
Date: 2017-02-21 12:58:21

On 21-Feb-2017, at 4:39 PM, Oliver O'Halloran [off-list ref] wrote:

On Tue, Feb 21, 2017 at 6:25 PM, abdul [off-list ref] wrote:
quoted
Hi,

Today's mainline build, breaks on Power6 and Power7 (all BE config) with
these build errors

arch/powerpc/kernel/time.c: In function ‘running_clock’:
arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function
‘cputime_to_nsecs’ [-Werror=implicit-function-declaration]
return local_clock() -
cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
^
cc1: some warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/time.o] Error 1


Regard's
Abdul Haleem
IBM Linux Technology Center.
Hi Abdul,

Are there any extra patches in your tree? I briefly tried to reproduce
this, but in my local tree this line:
I think the failure reported here is against linux-next tree.
Abdul can you confirm ?

With today’s linux-next tree I can recreate this build failure

  CC      arch/powerpc/kernel/sysfs.o
  CC      arch/powerpc/kernel/cacheinfo.o
  CC      arch/powerpc/kernel/time.o
arch/powerpc/kernel/time.c: In function 'running_clock':
arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration]
  return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
  ^
cc1: some warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/time.o] Error 1
make: *** [arch/powerpc/kernel] Error 2

This is with big endian config. I have attached the config file.
The system has gcc version 4.8.5

Thanks
- Sachin

Re: [PowerPC] 4.10.0 fails to build on BE config

From: Frederic Weisbecker <hidden>
Date: 2017-02-21 15:20:24

On Tue, Feb 21, 2017 at 12:55:35PM +0530, abdul wrote:
Hi,

Today's mainline build, breaks on Power6 and Power7 (all BE config) with
these build errors

arch/powerpc/kernel/time.c: In function ‘running_clock’:
arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function
‘cputime_to_nsecs’ [-Werror=implicit-function-declaration]
return local_clock() -
cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
^
cc1: some warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/time.o] Error 1
Thanks for reporting this!
I just sent a fix.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help