[PATCH] Remove extra include in HVC console tty framework

Subsystems: hypervisor virtual console driver, the rest, tty layer and serial drivers

STALE3551d

2 messages, 2 authors, 2017-01-31 · open the first message on its own page

[PATCH] Remove extra include in HVC console tty framework

From: Sergio Valverde <hidden>
Date: 2017-01-30 22:57:34

From: Sergio Valverde <redacted>

An extra "init.h" include is found in the HVC console code.

While the code works as it is right now, it is a defect nevertheless.
As such, the extra line is deleted.

Signed-off-by: Sergio Valverde <redacted>
---
 drivers/tty/hvc/hvc_console.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 9b5c0fb..b19ae36 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -29,7 +29,6 @@
 #include <linux/kernel.h>
 #include <linux/kthread.h>
 #include <linux/list.h>
-#include <linux/init.h>
 #include <linux/major.h>
 #include <linux/atomic.h>
 #include <linux/sysrq.h>
-- 
1.9.1

Re: [PATCH] Remove extra include in HVC console tty framework

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2017-01-31 05:23:32

On Mon, Jan 30, 2017 at 04:57:23PM -0600, Sergio Valverde wrote:
From: Sergio Valverde <redacted>

An extra "init.h" include is found in the HVC console code.

While the code works as it is right now, it is a defect nevertheless.
As such, the extra line is deleted.
It's not a "defect" as it's not wrong.  It's just an annoyance.  This
whole sentence should probably be removed.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help