# Re: \[RESEND\] cxl: Force psl data-cache flush during device shutdown

- From: Andrew Donnellan \<hidden\>
- Date: 2017-01-04 06:44:10 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2017/01/9494497
- Thread: https://ratatoskr.run/linuxppc-dev/2017/01/9494496/t.md

```text
On 04/01/17 17:18, Vaibhav Jain wrote:
> This change adds a force psl data cache flush during device shutdown
> callback. This should reduce a possibility of psl holding a dirty
> cache line while the CAPP is being reinitialized, which may result in
> a UE [load/store] machine check error.
>
> Signed-off-by: Vaibhav Jain <redacted>

Should this be cc: stable? (it does depend on aaa2245ed836 which only came in during 4.9)

Looks good.

Reviewed-by: Andrew Donnellan <redacted>



> ---
> Resend: Fixed the author ident.
> ---
>  drivers/misc/cxl/pci.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index 80a87ab..73432e7 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -1610,6 +1610,9 @@ static void cxl_pci_remove_adapter(struct cxl *adapter)
>  	cxl_sysfs_adapter_remove(adapter);
>  	cxl_debugfs_adapter_remove(adapter);
>
> +	/* Flush adapter datacache as its about to be removed */
> +	cxl_data_cache_flush(adapter);
> +
>  	cxl_deconfigure_adapter(adapter);
>
>  	device_unregister(&adapter->dev);
>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited
```