# Re: \[PATCH\] powerpc: sort Kconfig selects under CONFIG\_PPC

- From: Stephen Rothwell \<hidden\>
- Date: 2017-01-30 09:41:26 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2017/01/4923043
- Thread: https://ratatoskr.run/linuxppc-dev/2017/01/4922893/t.md

```text
Hi Andrew,

On Mon, 30 Jan 2017 20:30:02 +1100 Andrew Donnellan [ref] wrote:
>
> config PPC has a lot of selects under it. They're not sorted in any
> particular order, leading to merge conflicts when adding items at the end.
> 
> Sort them alphabetically.

Excellent, thanks.

> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Andrew Donnellan <redacted>
> ---
> 
> On top of linux-next 20170130

Probably best done on top of powerpc-next and I can cope with the
conflicts one more time.

> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 689cf9218b21..570195c8a86a 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -80,91 +80,91 @@ config ARCH_HAS_DMA_SET_COHERENT_MASK
>  config PPC

Could we add a comment just above asking that the selects be kept in order?

>  	bool
>  	default y
> -	select BUILDTIME_EXTABLE_SORT
> +	select ARCH_HAS_DEVMEM_IS_ALLOWED
> +	select ARCH_HAS_DMA_SET_COHERENT_MASK
-- 
Cheers,
Stephen Rothwell
```