Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

On Dez 28 2016, "Harisangam, Sharvari (S.)" [off-list ref] wrote:

+	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
+		SND_SOC_DAIFMT_AC97;

This is never true.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Andreas Schwab wrote:

quoted

quoted

+	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
+		SND_SOC_DAIFMT_AC97;

This is never true.

I think the right parenthesis should be at the end of the expression.

On Wed, Dec 28, 2016 at 03:50:57PM +0100, Andreas Schwab wrote:

On Dez 28 2016, "Harisangam, Sharvari (S.)" <sharvari.harisangam@visteon.=

com> wrote:

=20

quoted

+	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) =3D=3D
+		SND_SOC_DAIFMT_AC97;

=20
This is never true.
=20
Andreas.
=20
--=20
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED=

5

"And now for something completely different."

Ok. I missed the braces there. I will modify and resubmit the patch

-Thanks
Sharvari=