[PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub

Subsystems: linux for powerpc (32-bit and 64-bit), live patching, the rest

STALE3559d

5 messages, 5 authors, 2016-12-19 · open the first message on its own page

[PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub

From: Kamalesh Babulal <hidden>
Date: 2016-12-16 06:15:02 

commit 425595a7fc20 ("livepatch: reuse module loader code
to write relocations") offloads livepatch module relocation
write to arch specific module loader code.

Remove unused klp_write_module_reloc() function stub.

Signed-off-by: Kamalesh Babulal <redacted>
---
 arch/powerpc/include/asm/livepatch.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h
index a402f7f..47a03b9 100644
--- a/arch/powerpc/include/asm/livepatch.h
+++ b/arch/powerpc/include/asm/livepatch.h
@@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void)
 	return 0;
 }
 
-static inline int klp_write_module_reloc(struct module *mod, unsigned long
-		type, unsigned long loc, unsigned long value)
-{
-	/* This requires infrastructure changes; we need the loadinfos. */
-	return -ENOSYS;
-}
-
 static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip)
 {
 	regs->nip = ip;
-- 
2.7.4

Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub

From: Balbir Singh <bsingharora@gmail.com>
Date: 2016-12-16 09:24:18 


On 16/12/16 17:14, Kamalesh Babulal wrote:
quoted hunk
commit 425595a7fc20 ("livepatch: reuse module loader code
to write relocations") offloads livepatch module relocation
write to arch specific module loader code.

Remove unused klp_write_module_reloc() function stub.

Signed-off-by: Kamalesh Babulal <redacted>
---
 arch/powerpc/include/asm/livepatch.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h
index a402f7f..47a03b9 100644
--- a/arch/powerpc/include/asm/livepatch.h
+++ b/arch/powerpc/include/asm/livepatch.h
@@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void)
 	return 0;
 }
 
-static inline int klp_write_module_reloc(struct module *mod, unsigned long
-		type, unsigned long loc, unsigned long value)
-{
-	/* This requires infrastructure changes; we need the loadinfos. */
-	return -ENOSYS;
-}
-
Makes sense

Acked-by: Balbir Singh <bsingharora@gmail.com>

Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub

From: Petr Mladek <pmladek@suse.com>
Date: 2016-12-16 10:25:19 

On Fri 2016-12-16 11:44:24, Kamalesh Babulal wrote:
commit 425595a7fc20 ("livepatch: reuse module loader code
to write relocations") offloads livepatch module relocation
write to arch specific module loader code.

Remove unused klp_write_module_reloc() function stub.
Yup, the function is not longer used.

Signed-off-by: Kamalesh Babulal <redacted>
Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub

From: Josh Poimboeuf <hidden>
Date: 2016-12-16 15:18:18 

On Fri, Dec 16, 2016 at 11:44:24AM +0530, Kamalesh Babulal wrote:
commit 425595a7fc20 ("livepatch: reuse module loader code
to write relocations") offloads livepatch module relocation
write to arch specific module loader code.

Remove unused klp_write_module_reloc() function stub.

Signed-off-by: Kamalesh Babulal <redacted>
Acked-by: Josh Poimboeuf <redacted>

-- 
Josh

Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub

From: Jiri Kosina <jikos@kernel.org>
Date: 2016-12-19 10:16:59 

On Fri, 16 Dec 2016, Kamalesh Babulal wrote:
quoted hunk
commit 425595a7fc20 ("livepatch: reuse module loader code
to write relocations") offloads livepatch module relocation
write to arch specific module loader code.

Remove unused klp_write_module_reloc() function stub.

Signed-off-by: Kamalesh Babulal <redacted>
---
 arch/powerpc/include/asm/livepatch.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h
index a402f7f..47a03b9 100644
--- a/arch/powerpc/include/asm/livepatch.h
+++ b/arch/powerpc/include/asm/livepatch.h
@@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void)
 	return 0;
 }
 
-static inline int klp_write_module_reloc(struct module *mod, unsigned long
-		type, unsigned long loc, unsigned long value)
-{
-	/* This requires infrastructure changes; we need the loadinfos. */
-	return -ENOSYS;
-}
-
 static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip)
 {
 	regs->nip = ip;
Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help